Repository navigation
Customizer responsive sanitizer fatals when input is an array #4651
Description
Summary
When a responsive Customizer setting is submitted as an array, the sanitizer can terminate the request with a TypeError instead of returning a sanitized value. This interrupts the affected Customizer preview request.
Customer context
Product / area: Neve, Header Footer Grid responsive Customizer settings
Version: Neve 4.2.16
Environment: WordPress 7.1.3; PHP 8.3.31 and 8.4.26
Integration / third party: Not identified as relevant
Reported error / symptom: json_decode(): Argument #1 ($json) must be of type string, array given
Impact: The fatal interrupts the affected Customizer preview request; two sites were represented in telemetry.
Reproduction notes
Production telemetry captured this during a frontend request in the Customizer preview/sanitization path on Neve 4.2.16. The exact responsive setting and submitted payload are not available. The source-level failure can be exercised by calling sanitize_responsive_int_json() with an array on a PHP version that rejects non-string input to json_decode(); no local runtime reproduction was performed.
Diagnosis
Conclusion
Confirmed product defect: production telemetry records an array reaching sanitize_responsive_int_json(), and the Neve 4.2.16 implementation passes that value directly to json_decode(). The reported TypeError matches this source path.
Where this likely occurs
header-footer-grid/Traits/Core.php—Abstract_Component::sanitize_responsive_int_json()approx. lines 77–86 callsjson_decode($input, true)before validating the input type.header-footer-grid/Core/Builder/Abstract_Builder.php— responsive setting registration approx. lines 400–402 attaches the sanitizer callback.tests/test-neve-sanitization.php—do_assertion_for_sanitize_responsive_int_json()lines 241–243 JSON-encodes its array fixtures before invoking the sanitizer.
Engineering notes
The crash is reported for Neve 4.2.16 on PHP 8.3 and 8.4. The stack identifies the Customizer setting sanitization path, and the telemetry gives direct evidence that the callback received an array. Existing tests cover array-shaped values only after JSON encoding, not the native array input reported here. No regression boundary was identified; the method has existed since 2019.
Test coverage status
tests/test-neve-sanitization.php::test_sanitize_responsive_int_json() covers serialized JSON input, including fixtures initially represented as arrays. Its helper encodes those fixtures before the sanitizer call, so relevant native-array input coverage is absent from the inspected test path. No test suite was run.
What to verify or explore next
- Reproduce the reported Customizer callback path with a native array input on the affected PHP versions.
- Identify which responsive setting and client payload produce the array in the Customizer request.
- Confirm behavior for existing serialized-string inputs alongside the reported native-array case.
Unknowns / follow-up
The exact setting identifier, request payload, and triggering user interaction were not captured in the telemetry report.
Confidence
Confidence: 98/100
The Neve 4.2.16 Customizer crash is confirmed by production telemetry and source: the sanitizer passes the reported array directly to json_decode(). The three loader fingerprints all resolve to an unguarded require in Neve 4.1.4/4.2.2/4.2.6, while v4.2.14 contains a missing-file guard, so those older-version signals do not warrant a new issue when a fixed release is available.
Crash telemetry
| Occurrences | 20 |
| Distinct sites | 2 |
| First seen | 2026-10-07 20:18 UTC |
| Last seen | 2026-10-08 15:09 UTC |
| Crash location | product:header-footer-grid/Traits/Core.php:78 |
| Request context | frontend |
| Inside Themeisle SDK | no |
| Product versions | 4.2.16 |
| WP versions | 7.1.3 |
| PHP versions | 8.3.31, 8.4.26 |
| SDK versions | 3.3.66 |
Source: automated crash report — neve, fingerprint dd32a661da5a24e257d2836e290e0a41
Generated by bug-report-triage (ID: bug-report-triage_6ac883627ef247.03851758)
Activity
milicavs commentedon Oct 17, 2026
🧪 QA steps and test links
On Neve 4.2.16 the Customizer crashes with a fatal error (
json_decode(): Argument #1 ($json) must be of type string, array given) when a responsive header setting, such as a row's height, reaches it as already-decoded values instead of the usual saved text. Normal use of free Neve never does this; Neve Pro conditional headers do. The links and steps use a Code Snippet that hands the Customizer the Header Main row height the same way, so the crash shows on free Neve.9266937In the links:
debug.logshows the error above.Reproduce on Neve 4.2.16:
Edge cases
Fix: #4662 (open)
pirate-bot commentedon Oct 17, 2026
QA agent — 🟢 Passing checks · The array-input crash is fixed, and responsive header settings still save and render.
An equivalent native-array fixture reproduced the reported TypeError and HTTP 500 on the base build; the candidate loaded a usable Customizer and preview on both PHP versions. Free-theme and Pro conditional-header settings saved, survived reopening, and rendered correctly at desktop, tablet and mobile widths. Pro testing used a supported seeded license state, not real activation. The added tests and expanded sanitizer/save matrices passed.
Worth a human look
Checks (7 passed)
Full report, evidence and session trail
pirate-bot commentedon Oct 21, 2026
🎉 This issue has been resolved in version 4.2.17 🎉
The release is available on GitHub release
Your semantic-release bot 📦🚀