Restored legacy deletion settings to existing imports - #1309
Open
girishpanchal30 wants to merge 4 commits into
Open
Restored legacy deletion settings to existing imports#1309girishpanchal30 wants to merge 4 commits into
girishpanchal30 wants to merge 4 commits into
Conversation
Contributor
|
Plugin build for 0a2f9f0 is ready 🛎️!
Note You can preview the changes in the Playground |
Contributor
🌍 i18n String Review Report📊 Summary
➕ Added Strings (2) - Click to expand
|
There was a problem hiding this comment.
Pull request overview
Restores legacy per-import post and media deletion settings only for imports that previously stored them.
Changes:
- Restores legacy deletion controls and persistence behavior.
- Adds PHPUnit coverage for visibility and saving.
- Updates test bootstrap for SDK helpers.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
includes/admin/feedzy-rss-feeds-import.php |
Loads and saves legacy deletion metadata. |
includes/views/import-metabox-edit.php |
Renders legacy deletion controls conditionally. |
tests/test-import-legacy-settings.php |
Tests legacy setting visibility and persistence. |
tests/bootstrap.php |
Reloads the SDK loader during test bootstrap. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.
Suppressed comments (1)
includes/admin/feedzy-rss-feeds-import.php:765
- Clearing the new number input submits an empty string (the field is not required). This branch then deletes
import_feed_delete_days, so the legacy control disappears on the next edit and the import can fall back to the global deletion period instead of remaining disabled. Normalize an empty submitted value to the documented0state (or reject blank input) and add a regression test for this save path.
if ( ( 'default_thumbnail_id' === $key || 'import_feed_delete_days' === $key ) && '0' === $value ) { // Mark the feed as having no default fallback image or auto-delete days (including the global fallback).
selul
approved these changes
Aug 6, 2026
Soare-Robert-Daniel
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restored the legacy setting - auto-delete days for imported posts and delete attached media. The setting is only rendered for imports that already have it stored, so it won't create it for the rest.
Screenshots
Test instructions
Check before Pull Request is ready:
Closes https://github.com/Codeinwp/feedzy-rss-feeds-pro/issues/1010