Added fallback for IDN URL validation - #1307
Open
girishpanchal30 wants to merge 3 commits into
Open
Conversation
pirate-bot
added
the
pr-checklist-complete
Contributor
|
Plugin build for 827dd82 is ready 🛎️!
Note You can preview the changes in the Playground |
There was a problem hiding this comment.
Pull request overview
Adds WordPress Requests-based IDN conversion when PHP’s intl extension is unavailable.
Changes:
- Adds guarded
idn_to_ascii()usage and punycode fallback. - Expands IDN URL and featured-image tests.
- One featured-image regression assertion is currently vacuous.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
includes/admin/feedzy-rss-feeds-import.php |
Adds resilient IDN host conversion. |
tests/test-image-import.php |
Adds IDN conversion and image-import coverage. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
selul
requested changes
Aug 6, 2026
selul
left a comment
selul
left a comment
Contributor
There was a problem hiding this comment.
One new phpcs:ignore and a whitespace slip.
girishpanchal30
force-pushed
the
bugfix/1302
branch
from
August 6, 2026 08:45
df53f2c to
827dd82
Compare
Soare-Robert-Daniel
approved these changes
Aug 6, 2026
selul
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added a fallback for the
idn_to_ascii()function in case theintlextension is not available. This ensures that the plugin can handle internationalized domain names (IDNs) correctly, even on servers without theintlextension.Check before Pull Request is ready:
Closes #1302