[codex] Tolerate absolute file tool paths#632
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Keep file-editing tool prompts relative-path-first while making the SDK tolerant of absolute paths that resolve inside the project directory where the Codebuff CLI was started.
Root Cause
Absolute paths inside the project were failing in two places:
requestOptionalFileread absolute paths throughread_files, which normalized successful reads to relative keys, but then looked up the original absolute key.changeFilerejected every absolute edit path as traversal, even when the path resolved inside the project root.Changes
getProjectPathLookupKeys()so optional-file lookup does not duplicate knowledge of howgetFiles()keys normalized paths.str_replaceandwrite_fileschema/tool documentation relative-path-first so absolute paths remain client-side tolerance rather than first-class agent guidance.changeFileto a single-change flow instead of batch-style arrays...config.Validation
bun test sdk/src/__tests__/path-utils.test.ts sdk/src/__tests__/change-file.test.ts sdk/src/__tests__/read-files.test.ts sdk/src/__tests__/run-file-filter.test.tsbun run --cwd sdk typecheckbun run --cwd common typecheck