Project introducing stdout/stderr and error handling#116
Merged
Conversation
✅ Deploy Preview for cyf-systems ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
illicitonion
force-pushed
the
output-and-error-handling
branch
2 times, most recently
from
7526907 to
988f1c3
Compare
illicitonion
requested review from
RitaGlushkova,
SallyMcGrath,
berkeli,
sre-is-laura and
tgvashworth
sre-is-laura
reviewed
Feb 3, 2023
illicitonion
force-pushed
the
output-and-error-handling
branch
3 times, most recently
from
9b8f520 to
2cf89cb
Compare
There is a lot of "teaching" material in this project, and I'd love to cite some external references rather than writing new material, but I couldn't find any particularly accessible (and not-very-language-specific) introductions to the concepts...
illicitonion
force-pushed
the
output-and-error-handling
branch
from
f126abe to
6d7d72d
Compare
Member
Author
|
All addressed, and reference impl added in #117 |
illicitonion
force-pushed
the
output-and-error-handling
branch
from
6d7d72d to
9c476f5
Compare
- knocked down reading level from postgraduate to grade 6 - broke up long sentences into bullet points - removed equivocation YOU MAY WISH TO LOOK CAREFULLY AT - 1. PROPAGATING THE ERROR TO THE CALLING FUNCTION 3. TERMINATING THE PROGRAM COMPLETELY I have added footnotes to replace some extremely extended parentheses. I have added hrs and I will put in a style for them now
sre-is-laura
approved these changes
Feb 6, 2023
SallyMcGrath
previously requested changes
Feb 6, 2023
SallyMcGrath
left a comment
SallyMcGrath
left a comment
Member
There was a problem hiding this comment.
I left my comments directly on the commit so it's clearer. A few tiny things.
PS SORRY ABOUT THE SMART QUOTES
illicitonion
dismissed
SallyMcGrath’s stale review
Sally is unavailable, but review comments have been addressed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a lot of "teaching" material in this project, and I'd love to cite some external references rather than writing new material, but I couldn't find any particularly accessible (and
not-very-language-specific) introductions to the concepts...