Skip to content

Implementation of multiple-servers project#10

Open
tgvashworth wants to merge 16 commits into
mainfrom
impl/multiple-servers
Open

Implementation of multiple-servers project#10
tgvashworth wants to merge 16 commits into
mainfrom
impl/multiple-servers

Conversation

@tgvashworth
Copy link
Copy Markdown
Collaborator

@tgvashworth tgvashworth commented Aug 14, 2022

@tgvashworth
Copy link
Copy Markdown
Collaborator Author

@illicitonion Thoughts on the architecture of this?

Copy link
Copy Markdown
Member

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The general shape looks great!

I'm looking forward to working out how we introduce the concept of an entire apache config in a digestable manner :D

We may want to introduce a small cache or something somewhere (either in the API servers or the Apache?) to better justify why we may be replicating them? Or maybe that's for a different project?

And we may even want to introduce the idea of a CDN for the static files?

I left a couple of random thoughts from skimming the code, but realise this isn't at code-review readiness yet :)

Comment thread multiple-servers/api/api.go Outdated
Comment thread multiple-servers/api/api.go Outdated
@tgvashworth tgvashworth force-pushed the impl/multiple-servers branch from f9006a5 to 054f55d Compare August 21, 2022 17:06
Copy link
Copy Markdown
Member

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants