Glasgow | May-2026 | Craig Stoddart | Sprint 1 | Form Controls by CraigStodd · Pull Request #1413 · CodeYourFuture/Module-Onboarding

CraigStodd · 2026-06-04T12:41:07Z

LINK TO PREVIOUS PR:

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

Updated to include changes suggested in previous pull request.
Implemented changes that meet all requirements for the Form Control exercise

…dded remaining sizes

- Removed capital letters for id tags in lines 46-47 - Reformatted code with: shift + option + F

-Added value="" to and removed "disabled attribute" from t-shirt colour section

…), ensuring 2 non-space characters requirement

netlify · 2026-06-04T12:41:12Z

✅ Deploy Preview for cyf-onboarding-module ready!

Name	Link
🔨 Latest commit	`537aeb3`
🔍 Latest deploy log	https://app.netlify.com/projects/cyf-onboarding-module/deploys/6a217266ab8d4b0008ff0e27
😎 Deploy Preview	https://deploy-preview-1413--cyf-onboarding-module.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	2 paths audited Performance: 100 (no change from production) Accessibility: 100 (no change from production) Best Practices: 100 (no change from production) SEO: 86 (no change from production) PWA: - View the detailed breakdown and full score reports
🤖 Make changes	Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

CraigStodd · 2026-06-04T15:44:25Z

Hi @cjyuan, here is the updated PR with the changes you suggested.

cjyuan

Changes look good.

I only a few more minor requests.

cjyuan · 2026-06-04T16:15:43Z

+              <label
+                >XS:
+                <input type="radio" name="Size" value="XS" required />
+              </label>


Could you look up "Should the text associated with a radio button be placed on left or right of the radio button?"

Change is optional.

Sure, I'll look into it.

cjyuan · 2026-06-04T16:18:02Z

+          </div>
+        </div>
+
+        <br />


Consider using CSS to control spacing between elements instead of using <br> tags. This approach is generally more maintainable and semantically correct.

cjyuan · 2026-06-04T16:21:36Z

+
+              <label
+                >S:
+                <input type="radio" name="Size" value="S" required />


The convention is to use lowercase kebab-case values for the name attribute (and also for id and class attributes)

Noted, I'll change this.

CraigStodd · 2026-06-05T11:28:11Z

Hi @cjyuan, I've implemented the changes you suggested. Let me know if there are any further issues. Thanks.

cjyuan · 2026-06-05T12:32:36Z

I don't see any new commits on this branch.
- Check if you have pushed the commits made on your computer to GitHub.
- Check if you have made the commits on the right branch.
When this PR is ready to be re-reviewed, add a "Needs review" label to this PR.

CraigStodd · 2026-06-05T13:09:39Z

They appear to have gone to this repository: https://github.com/CraigStodd/Module-Onboarding/tree/Glasgow-May-2026-Craig-Stoddart-Sprint-1-Form-Control.

I'm not sure how to fix this. I think renaming the branches has complicated things.

cjyuan · 2026-06-05T13:52:57Z

It seems that branch is not related to any opened PR, so I don't think changing it will affect your current PRs.

The easiest way to transfer your changes to this branch is

Switch to this branch. On VS Code, the "current branch name" is usually located at the lower left corner of the VS Code window.
Update the two files on this branch (copying your code from the "Glasgow...-Form-Control" branch is one option).
Commit the change and push the commit to GitHub.

Note: I think what happened was that you renamed the "Glasgow ..." branch on GitHub, but not on your computer, and you continued working on your original "Glasgow ..." branch on your computer. When you pushed the original branch to GitHub, the "Glasgow ..." branch was recreated on GitHub".

If the feature/form-control branch does not exist on your computer, you can fetch it from GitHub.

CraigStodd added 17 commits May 12, 2026 14:47

Changed "HOMEWORK SOLUTION" to my name

8e42931

Added Requirements in comments

4ea3905

Updated "Full Name" input to specify input type, id and name

37ba83c

Added Email label; added colons to label titles

ae6e173

Added template code for "T-Shirt Size" checkbox

a4dbbe1

Changed "T-Shirt Size" checkbox-style button to radio-style button; a…

770726e

…dded remaining sizes

Added "T-Shirt Colour" section

33d6910

Cleaned up Comments for readability

53f0989

Added basic style sheet with text formatting

0728ba1

Added Grid Container

8576e9d

Changed container type; changed h1 to "T-Shirt Order"

15bf3af

Removed whitespace from T-Shirt Colour"; removed stray div tag

a851094

Fixed Label end tags

efae5ad

- Removed capital letters in stylesheet ref, line 10

c2864c8

- Removed capital letters for id tags in lines 46-47 - Reformatted code with: shift + option + F

- Removed id tag from radio buttons

fbeac8a

-Added required attributes to each form section

01455f7

-Added value="" to and removed "disabled attribute" from t-shirt colour section

- Added pattern + title attributes to Full Name" section (lines 32-33…

537aeb3

…), ensuring 2 non-space characters requirement

CraigStodd added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 4, 2026

cjyuan reviewed Jun 4, 2026

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jun 4, 2026

+                        </div>
+                      </div>
+                      <br />

Uh oh!

Conversation

CraigStodd commented Jun 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Learners, PR Template

Changelist

Uh oh!

netlify Bot commented Jun 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for cyf-onboarding-module ready!

Uh oh!

CraigStodd commented Jun 4, 2026

Uh oh!

cjyuan left a comment

Choose a reason for hiding this comment

Uh oh!

cjyuan Jun 4, 2026

Choose a reason for hiding this comment

Uh oh!

CraigStodd Jun 5, 2026

Choose a reason for hiding this comment

Uh oh!

cjyuan Jun 4, 2026

Choose a reason for hiding this comment

Uh oh!

CraigStodd Jun 5, 2026

Choose a reason for hiding this comment

Uh oh!

cjyuan Jun 4, 2026

Choose a reason for hiding this comment

Uh oh!

CraigStodd Jun 5, 2026

Choose a reason for hiding this comment

Uh oh!

CraigStodd commented Jun 5, 2026

Uh oh!

cjyuan commented Jun 5, 2026

Uh oh!

CraigStodd commented Jun 5, 2026

Uh oh!

cjyuan commented Jun 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

CraigStodd commented Jun 4, 2026 •

edited

Loading

netlify Bot commented Jun 4, 2026 •

edited

Loading

cjyuan commented Jun 5, 2026 •

edited

Loading