Skip to content

Birmingham|26-ITP-May|Yonas Gebre|Sprint 2|Wireframe#1412

Open
yonasdesbelegebre wants to merge 6 commits into
CodeYourFuture:mainfrom
yonasdesbelegebre:articles
Open

Birmingham|26-ITP-May|Yonas Gebre|Sprint 2|Wireframe#1412
yonasdesbelegebre wants to merge 6 commits into
CodeYourFuture:mainfrom
yonasdesbelegebre:articles

Conversation

@yonasdesbelegebre
Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • [X ] I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • [ X] My changes meet the requirements of the task
  • [ X] I have tested my changes
  • [ X] My changes follow the style guide

Changelist

Based on the Wireframe, I have created the Title for the article and small explanation about the page.
The wireframe have 3 articles, one on top and other two side by side.
These article contains images, title and content as well as the link to read more page.
The footer is about who developed the page and how they contact us.

@netlify
Copy link
Copy Markdown

netlify Bot commented Jun 4, 2026

Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 953e387
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/6a216d63399d530008adbd4e
😎 Deploy Preview https://deploy-preview-1412--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 91 (🟢 up 5 from production)
PWA: -
View the detailed breakdown and full score reports
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@yonasdesbelegebre yonasdesbelegebre added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 4, 2026
@akeren akeren added 📅 Sprint 2 Assigned during Sprint 2 of this module Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. Module-Onboarding The name of the module. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jun 5, 2026
@akeren akeren self-requested a review June 5, 2026 10:52
Copy link
Copy Markdown

@akeren akeren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yonasdesbelegebre, your codebase is well-structured. However, the root directory of your project has a lot of files.

How could you organise your folders so the project stays easy to navigate, scalable and maintainable now and in the future?

@akeren akeren added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Jun 5, 2026
@yonasdesbelegebre
Copy link
Copy Markdown
Author

@yonasdesbelegebre, your codebase is well-structured. However, the root directory of your project has a lot of files.

How could you organise your folders so the project stays easy to navigate, scalable and maintainable now and in the future?

Thank you for the feedback, I will create folders for images and the pages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Module-Onboarding The name of the module. Reviewed Volunteer to add when completing a review with trainee action still to take. 📅 Sprint 2 Assigned during Sprint 2 of this module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants