Glasgow | 26-ITP-May | Francesco Romano Monda | Sprint 2 | Wireframe to Web Code#1409
Open
fromonda wants to merge 4 commits into
Open
Glasgow | 26-ITP-May | Francesco Romano Monda | Sprint 2 | Wireframe to Web Code#1409fromonda wants to merge 4 commits into
fromonda wants to merge 4 commits into
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
fromonda
added
the
Needs Review
akeren
added
📅 Sprint 2
akeren
reviewed
Jun 5, 2026
akeren
left a comment
akeren
left a comment
There was a problem hiding this comment.
@fromonda, your codebase structure is currently simple and easy to follow, with files kept in the same root directory.
- As your projects grow, what might happen if you later add more
CSS files,JavaScript files,images, or multipleHTML pages? - How could you organise your folders so the project stays easy to navigate, scalable and maintainable now and in the future?
Comment on lines
57
to
62
| <footer> | ||
| <p> | ||
| This is the default, provided code and no changes have been made yet. | ||
| Built using semantic HTML, CSS layout techniques, and version control | ||
| practices. | ||
| </p> | ||
| </footer> |
There was a problem hiding this comment.
@fromonda, examine the footer position in the rendered UI. Where should it sit relative to the rest of the page, and what styling might need to change?
| This is the default, provided code and no changes have been made yet. | ||
| </p> | ||
| <p>Learn about README files, wireframes, and Git branches.</p> | ||
| </header> |
There was a problem hiding this comment.
@fromonda, when you compare the header with the main body, does the UI alignment look intentional? What CSS change might help align them?
| <title>Wireframe</title> | ||
| <link rel="stylesheet" href="style.css" /> | ||
| </head> | ||
|
|
There was a problem hiding this comment.
@fromonda, could you explain why you've added this empty line?
akeren
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist