London | 26-ITP-May | Vito Moratti | Sprint 1 | Feature/form controls#1396
Open
vmoratti wants to merge 7 commits into
Open
London | 26-ITP-May | Vito Moratti | Sprint 1 | Feature/form controls#1396vmoratti wants to merge 7 commits into
vmoratti wants to merge 7 commits into
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
vmoratti
added
the
Needs Review
Luro91
reviewed
Jun 3, 2026
| <legend>Name and Email address</legend> | ||
| <!--Adding <legend> element for accessibility purposes--> | ||
| <label for="name">Name</label> | ||
| <input type="text" id="name" name="name" minlength="2" pattern="[a-zA-Z]+" required><br><br> |
There was a problem hiding this comment.
This does not allow special characters like the German ä,ü,ö
Author
There was a problem hiding this comment.
I have made an adjustment to allow for German characters
There was a problem hiding this comment.
How can you allow all valid characters for all languages? Like Chinese, Russian and others
Author
There was a problem hiding this comment.
I have made an adjustment to the name field.
I was doing it wrong, i was applying alphabet allowances where all alphabets are allowed anyway with UTF-8 i believe. So, all i needed to do is only make restrictions on two non space characters.
| <title>My form exercise</title> | ||
| <meta name="description" content="" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1" /> | ||
| <link rel="stylesheet" href="style.css" /> |
There was a problem hiding this comment.
Good job that you separated the CSS into its own file—that’s an excellent best practice and will make your code much easier to read, debug, and maintain as it grows.
Luro91
added
Reviewed
Updated name input pattern to include accented characters.
vmoratti
added
the
Needs Review
Luro91
removed
the
Needs Review
Updated input fields for name and radio buttons for color and size to remove unnecessary 'required' attributes.
vmoratti
added
the
Needs Review
Luro91
reviewed
Jun 5, 2026
Luro91
left a comment
Luro91
left a comment
There was a problem hiding this comment.
Well done the code works as expected and easy to read.
Luro91
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
I was struggling with "push" and with PRs. I had to delete previous branches and start from scratch.
I hope it works this time.