Birmingham | 26-ITP-May | Fahman ALQADASI | Sprint 1 | Form Control#1377
Open
falqadasy-svg wants to merge 2 commits into
Open
Birmingham | 26-ITP-May | Fahman ALQADASI | Sprint 1 | Form Control#1377falqadasy-svg wants to merge 2 commits into
falqadasy-svg wants to merge 2 commits into
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This comment has been minimized.
This comment has been minimized.
5 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
falqadasy-svg
changed the title
falqadasy-svg
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
falqadasy-svg
changed the title
Contributor
|
Note: This PR has no label. |
falqadasy-svg
added
the
Needs Review
cjyuan
added
the
Review in progress
cjyuan
reviewed
Jun 4, 2026
Contributor
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
- Can you improve the Lighthouse accessibility score from 90 to 100?
Comment on lines
+25
to
+26
| <label for="product-name">Product Name:</label> | ||
| <input type="text" id="product-name" placeholder="Product Name" required pattern="^[a-zA-Z\s]+$" maxlength="20" minlength="2"/> |
Contributor
There was a problem hiding this comment.
-
Do you mean "User name"?
-
Can you also fix this input field so that it will not accept any name containing only space characters?
Comment on lines
+33
to
+39
| <label >T shirt color:</label> | ||
| <select name="color" required> | ||
| <option value="">Select a color</option> | ||
| <option value="red">Red</option> | ||
| <option value="blue">Blue</option> | ||
| <option value="green">Green</option> | ||
| </select> |
Contributor
There was a problem hiding this comment.
Code is not indented or formatted consistently.
Please consider following this guide to enable VS Code's
"Format on Save" option or to use its "Format Document" command to ensure your code is always consistently formatted.
cjyuan
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
I have created some field like
user name
the email
the colour
the size
the submit
the name of the creator