Skip to content

WestMidlands | 26-ITP-May | Gabriel Pawuoi | Sprint 1 | Form Controls#1314

Open
KhotKeys wants to merge 3 commits into
CodeYourFuture:mainfrom
KhotKeys:forms-project
Open

WestMidlands | 26-ITP-May | Gabriel Pawuoi | Sprint 1 | Form Controls#1314
KhotKeys wants to merge 3 commits into
CodeYourFuture:mainfrom
KhotKeys:forms-project

Conversation

@KhotKeys
Copy link
Copy Markdown

@KhotKeys KhotKeys commented May 18, 2026 •
edited
Loading

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

  • Form components html and css additional requirements added successfully

@netlify
Copy link
Copy Markdown

netlify Bot commented May 18, 2026 •
edited
Loading

✅ Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit bf756b0
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/6a18477e15b4e700076f519e
😎 Deploy Preview https://deploy-preview-1314--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions

This comment has been minimized.

Sign in to view
@KhotKeys KhotKeys added 📅 Sprint 1 Assigned during Sprint 1 of this module 🦑 Size Large 4-8 hours Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Submit:PR This work is submitted by creating a PR against CodeYourFuture's fork of this repo. Module-Onboarding The name of the module. labels May 18, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 18, 2026
@github-actions

This comment has been minimized.

Sign in to view
3 similar comments
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@KhotKeys KhotKeys added the 🏕 Priority Mandatory This work is expected label May 18, 2026
@github-actions

This comment has been minimized.

Sign in to view
@KhotKeys KhotKeys added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed 🏕 Priority Mandatory This work is expected 🦑 Size Large 4-8 hours Submit:PR This work is submitted by creating a PR against CodeYourFuture's fork of this repo. labels May 18, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 18, 2026
@github-actions

This comment has been minimized.

Sign in to view
2 similar comments
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@jayshreehajgude2012 jayshreehajgude2012 added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label May 20, 2026
@github-actions

This comment has been minimized.

Sign in to view
jayshreehajgude2012
jayshreehajgude2012 reviewed May 20, 2026
View reviewed changes
Copy link
Copy Markdown

@jayshreehajgude2012 jayshreehajgude2012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

link CSS file with html.

Comment thread Form-Controls/index.html
<form>
<div>
<label for="name">Full Name</label>
<input type="text" id="name"name="name" minlength="2" pattern=".*\S.*\S.*" placeholder="Enter your full name" required>
Copy link
Copy Markdown

@jayshreehajgude2012 jayshreehajgude2012 May 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Input validation done
placeholder use

Copy link
Copy Markdown
Author

@KhotKeys KhotKeys Jun 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the requested changes are implemented!

Comment thread Form-Controls/index.html

<div>
<label for="email">Email Address</label>
<input type="email" id="email" name="email" placeholder="Enter your email" required>
Copy link
Copy Markdown

@jayshreehajgude2012 jayshreehajgude2012 May 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct Input type and required is used .
can you tell how to validate email without using email type

Copy link
Copy Markdown
Author

@KhotKeys KhotKeys May 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the feedback. Since the assignment was limited to HTML and CSS, I used type="email" with the required attribute for built-in browser validation.

@jayshreehajgude2012 jayshreehajgude2012 removed the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label May 20, 2026
@jayshreehajgude2012 jayshreehajgude2012 added the Reviewed Volunteer to add when completing a review with trainee action still to take. label May 20, 2026
@github-actions

This comment has been minimized.

Sign in to view
1 similar comment
@github-actions

This comment has been minimized.

Sign in to view
@KhotKeys KhotKeys added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label May 21, 2026
@github-actions

This comment has been minimized.

Sign in to view
@KhotKeys KhotKeys added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels May 30, 2026
@KhotKeys KhotKeys moved this to 🔖 Ready in Coursework Planner Board Jun 1, 2026
@KhotKeys KhotKeys moved this from 🔖 Ready to ✅ Done in Coursework Planner Board Jun 1, 2026
@KhotKeys KhotKeys mentioned this pull request Jun 2, 2026
Open
@KhotKeys KhotKeys added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jun 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jayshreehajgude2012 jayshreehajgude2012 jayshreehajgude2012 left review comments

Reviewers whose approvals may not affect merge requirements

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

Module-Onboarding The name of the module. Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. 📅 Sprint 1 Assigned during Sprint 1 of this module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@KhotKeys @jayshreehajgude2012