London | ITP-MAY-2026 | Ebrahim Moqbel | sprint 2 | Wireframe to Web code#1242
Open
Ebrahim-Moqbel wants to merge 23 commits into
Open
London | ITP-MAY-2026 | Ebrahim Moqbel | sprint 2 | Wireframe to Web code#1242Ebrahim-Moqbel wants to merge 23 commits into
Ebrahim-Moqbel wants to merge 23 commits into
Conversation
…/Module-Onboarding into feature/wireframe
images for the website
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This comment has been minimized.
This comment has been minimized.
|
Wireframe must be in sprint 2. They changed it from the Jan cohort. |
Contributor
|
@Ebrahim-Moqbel - I believe you still need to add a "Needs Review" label to this work for it to be reviewed by a volunteer and submitted |
Contributor
^^ Agreed with this, your PR title doesn't reflect the sprint that Wireframe to Web Code actually sits in now |
Author
|
Thank you I will update it accordingly |
Ebrahim-Moqbel
changed the title
This comment has been minimized.
This comment has been minimized.
Ebrahim-Moqbel
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
Ebrahim-Moqbel
added
the
Needs Review
Sambuxc
added
Review in progress
Sambuxc
reviewed
Jun 5, 2026
Sambuxc
left a comment
Sambuxc
left a comment
There was a problem hiding this comment.
Hi please take a look at the questions I've raised in your file changes. Thanks :)
| <article> | ||
| <img src="placeholder.svg" alt="" /> | ||
| <h2>Title</h2> | ||
| <img src="/Wireframe/img/README.png" alt="" /> |
|
|
||
| </p> | ||
| <a href="">Read more</a> | ||
| <a href="https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-readmes">Read more</a> |
There was a problem hiding this comment.
How would you make this link open in a new tab?
| } | ||
|
|
||
| /* ====== Footer ====== */ | ||
| .footer { |
There was a problem hiding this comment.
Is there a reason you have used a class named .footer rather than selector the footer element directly with its semantic tag?
Sambuxc
added
Reviewed
Sambuxc
reviewed
Jun 5, 2026
| @@ -1,3 +1,3 @@ | |||
| <!DOCTYPE html> | |||
| <html lang="en"> | |||
| <head> | |||
There was a problem hiding this comment.
Can you check if you've added all the required head tags and update where needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
I have a added content and images with layout standing by CSS and HTML