London | 26-ITP-May | Zadri Abdule | Sprint 2 | Wireframe#1222
Closed
Zadri415 wants to merge 36 commits into
Closed
London | 26-ITP-May | Zadri Abdule | Sprint 2 | Wireframe#1222Zadri415 wants to merge 36 commits into
Zadri415 wants to merge 36 commits into
Conversation
Fix links inconsistencies and remove ellipsis in HTML.
Updated the alt attribute of an image to provide a description.
Zadri415
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Zadri415
changed the title
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
Zadri415
added
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
This comment has been minimized.
This comment has been minimized.
Zadri415
changed the title
This comment has been minimized.
This comment has been minimized.
Zadri415
added
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
This comment has been minimized.
This comment has been minimized.
Zadri415
changed the title
This comment has been minimized.
This comment has been minimized.
Zadri415
added
the
Needs Review
Zadri415
changed the title
cjyuan
reviewed
May 12, 2026
Contributor
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
Code looks good.
To better match the wireframe, can you
- Make all images span the full width of their respective article?
- Align the height of the images in the bottom two articles? (Don't worry about the images being stretched)
Also, can you restore the level-2 header "Changelist" in the PR description? It should looks like this:
Changelist
cjyuan
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Added three articles
Added a responsive layout, header, footer, improved accessibility.