London | 26-Sep-ITP | Frumentius Tesfay | Sprint 3 | Coursework by Frumentius-Rev · Pull Request #1589 · CodeYourFuture/Module-JavaScript-Fundamentals

Frumentius-Rev · 2026-09-25T09:36:45Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Task code

CYF-1053

Changelist

I have demonstrated debugging and interpretation skills and completed the Sprint 3 requirements.

netlify · 2026-09-25T09:36:51Z

✅ Deploy Preview for cyf-onboarding-module ready!

Name	Link
🔨 Latest commit	`a6a94bc`
🔍 Latest deploy log	https://app.netlify.com/projects/cyf-onboarding-module/deploys/6abbafdfce817e00094e885f
😎 Deploy Preview	https://deploy-preview-1589--cyf-onboarding-module.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	2 paths audited Performance: 100 (no change from production) Accessibility: 100 (no change from production) Best Practices: 100 (no change from production) SEO: 86 (no change from production) PWA: - View the detailed breakdown and full score reports
🤖 Make changes	Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

Frumentius-Rev · 2026-09-25T09:49:23Z

Hey, I removed one of the code comments but left the others. I’ll make sure to remove all unnecessary comments next time to keep the code tidy and professional.

madhuranakate · 2026-09-25T11:30:30Z

+// If I give the new variable a different name, I hope it should work :)
+
+function capitalise(str) {
+  let newString = `${str[0].toUpperCase()}${str.slice(1)}`;


good analysis but can be variable name be something better ? a name that suggests what it holds

oh, you’re right! I didn’t focus on using a descriptive name in the first place. I think capitalisedString is clearer and tidier. Thank you for pointing that out!

madhuranakate · 2026-09-25T11:36:18Z

+  return percentage;
+}
+
+console.log(convertToPercentage("26"));


Although the updated function is correct, could you check again what parameter says should be passed into the function ?

madhuranakate · 2026-09-25T11:39:54Z

+  console.log(a * b);
+  return a * b;
+}
+console.log(`The result of multiplying 10 and 32 is ${multiply(10, 32)}`);


Is there a possibility that the logs are being duplicated ?

madhuranakate · 2026-09-25T11:49:55Z

 // This might help https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/toUpperCase
+
+function toUpper(input) {
+  return input.replaceAll(" ", "_").toUpperCase();


apart from uppercase, is this function perhaps adding something that does not exist in the input ?

Yeah, I noticed that it also replaces the spaces with underscores besides converting to uppercase.

madhuranakate · 2026-09-25T12:01:48Z


 // c) What is the return value of pad when it is called for the first time?
-// =============> write your answer here
+// 00


even though the answer is correct, could it perhaps be a different return type ?

madhuranakate · 2026-09-25T12:01:54Z


 // e) What is the return value of pad when it is called for the last time in this program?  Explain your answer
-// =============> write your answer here
+// 01


even though the answer is correct, could it perhaps be a different return type ?

abdishakoor-dev

Thanks for the fixes. capitalisedString is a clear name, and the quotes in c) and e) are right now.

A few things before this can be marked Complete:

2-mandatory-debug/0.js still prints the result twice. See my comment on line 6.
1-key-errors/1.js: see my comment on line 32.
time-format.js d) and e) both say "Explain your answer". Lines 36 and 39 give only the value. Add a short reason to each.
3-to-pounds.js: see my comment on line 24.
2-mandatory-debug/2.js: see my comment on line 28.
2-cases.js: see my comment on line 18.
2-mandatory-debug/0.js fails Prettier. Line 21 has spaces on an empty line. Right click in the file, choose Format Document, save and push. To format every time you save, follow the steps here: https://github.com/CodeYourFuture/Module-JavaScript-Fundamentals/blob/main/practical_guide.md

Add the Needs Review label again once you've pushed.

abdishakoor-dev · 2026-09-28T14:18:14Z

 // =============> write your prediction here
+// I believe the function will calculate 10 x 32

 function multiply(a, b) {


Lines 6 to 10 are the original code, and they still run. That is why the result prints twice. How did you stop the original code running in your other files?

Prints once now. Good.

abdishakoor-dev · 2026-09-28T14:18:14Z

+  return percentage;
+}
+
+console.log(convertToPercentage(26));


The parameter is called decimalNumber. convertToPercentage(26) prints 2600%. Is 26 a decimal number? What would you pass to get 26%?

0.7 gives 70%. Good.

abdishakoor-dev · 2026-09-28T14:18:14Z

+  return `£${pounds}.${pence}`;
+}
+
+console.log(toPounds("1250p"));


Line 6 asks you to call the function a number of times, with different inputs. Line 24 calls it once. Try a few more, for example a short one and a long one.

Good, three different inputs now.

abdishakoor-dev · 2026-09-28T14:18:14Z

 // Finally, correct the code to fix the problem
 // =============> write your new code here

+const num = 103;


Is num on line 28 used now? Your function uses its own num parameter. If line 28 is not needed, remove it.

Removed, good. A note for next time: two empty lines are left where it was, and Prettier flags them. With format on save turned on, Prettier removes them for you.

Alright, I will. Thanks

abdishakoor-dev · 2026-09-28T14:18:14Z

 // Use the MDN string documentation to help you find a solution
 // This might help https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/toUpperCase
+
+function toUpper(input) {


Function names should tell others what the function does. toUpper only describes part of it. If you use toUpperCase() as an inspiration, what would be a better name for this function?

toUpperSnakeCase is the one.

Frumentius-Rev · 2026-09-29T12:42:31Z

Thanks for the feedback! It helps me a lot and helps me see things from a different perspective. I’ve addressed all the comments and pushed the fixes. Everything should now be ready for review. 🌱

abdishakoor-dev

That's everything from the list, and d) and e) now explain why. Marking this Complete, well done.

I've left two small notes inline for next time. They don't need changes here.

abdishakoor-dev · 2026-09-29T16:15:44Z

+// If I give the new variable a different name, I hope it should work :)
+
+function capitalise(str) {
+  let capitalisedString = `${str[0].toUpperCase()}${str.slice(1)}`;


For next time: capitalisedString is never given a new value, so it can be const instead of let. The same goes for BMI in 1-bmi.js line 18. Use let only when the value changes later.

abdishakoor-dev · 2026-09-29T16:15:44Z


 // You should call this function a number of times to check it works for different inputs
+
+function toPounds(amount) {


For next time: amount could be any kind of amount. The input is a string of pence, like "50p". A name like penceString tells the reader that.

Exactly! I will it in mind.

Frumentius-Rev added 12 commits September 22, 2026 17:17

Fix capitalise function

d83f34c

Fix % conversion

dc3752d

Fix parameter name

53921fe

Debug return value

62255c0

Debug return statement

d423953

Debug last digit function

47e5c24

Complete BMI function

6189cca

Complete uppercase conversion

d8b60b7

Complete £ function

20b12f0

Complete function tracing exercise

706a763

Complete function tracing answers

7d4385b

Format Sprint 3 with Prettier

107eaf2

Frumentius-Rev added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 25, 2026

madhuranakate added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Sep 25, 2026

madhuranakate reviewed Sep 25, 2026

View reviewed changes

Frumentius-Rev added 4 commits September 25, 2026 22:49

Update variable naming

9a02929

Remove quotes from percentage

cf22a51

Remove duplicated log

d9e2cde

Clarifing return value types

365fc3a

Frumentius-Rev added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 25, 2026

abdishakoor-dev reviewed Sep 28, 2026

View reviewed changes

Frumentius-Rev force-pushed the acoursework/sprint-3 branch 2 times, most recently from 9f31e1e to 6b8ec14 Compare September 28, 2026 15:45

Frumentius-Rev added 4 commits September 28, 2026 17:04

Update to uppersnamecase

0c6b704

Update Convert decimal to percentage

da302ee

Update add comments

bc5bd0e

Remove unused const num

9723adb

Frumentius-Rev force-pushed the acoursework/sprint-3 branch from 6b8ec14 to 9723adb Compare September 28, 2026 16:27

Frumentius-Rev added 3 commits September 29, 2026 13:06

Test with diffrerent inputs value

30c1a82

Asswer time-format questions

88556ed

Format debug file

a6a94bc

Frumentius-Rev added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 29, 2026

abdishakoor-dev reviewed Sep 29, 2026

View reviewed changes


		// You should call this function a number of times to check it works for different inputs

		function toPounds(amount) {

Uh oh!

Conversation

Frumentius-Rev commented Sep 25, 2026

Learners, PR Template

Task code

Changelist

Uh oh!

netlify Bot commented Sep 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for cyf-onboarding-module ready!

Uh oh!

Frumentius-Rev commented Sep 25, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

abdishakoor-dev left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Frumentius-Rev commented Sep 29, 2026

Uh oh!

abdishakoor-dev left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

netlify Bot commented Sep 25, 2026 •

edited

Loading