Cape Town | 26-ITP-Sept | Lamla Kamana | Sprint 2 | JavaScript Fundamentals Coursework - #1569
Open
lamlakamana-oss wants to merge 24 commits into
Open
lamlakamana-oss wants to merge 24 commits into
lamlakamana-oss wants to merge 24 commits into
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This comment has been minimized.
This comment has been minimized.
lamlakamana-oss
changed the title
This comment has been minimized.
This comment has been minimized.
Fix explanation for percentage-change.js syntax error
Author
|
Thanks Dustin, You're right, the real issue was a missing comma between the two arguments in .replaceAll(), not extra brackets. I've updated the explanation to reflect that. Appreciate you flagging it. |
lamlakamana-oss
added
the
Needs Review
lamlakamana-oss
changed the title
lamlakamana-oss
changed the title
Luro91
reviewed
Oct 2, 2026
Luro91
left a comment
Luro91
left a comment
There was a problem hiding this comment.
Well done on solving the exercise. There is only one question left to answer
Luro91
added
Reviewed
Luro91
reviewed
Oct 2, 2026
Luro91
left a comment
Luro91
left a comment
There was a problem hiding this comment.
Well done.
Please also use the review_required next time when you are done with your changes and want feedback again.
Please note that in CYF courses, the recommended way to inform the reviewer of your changes is to do both of the following:
- Reply to their feedback.
- In the responses, clarify how each piece of feedback was addressed to demonstrate that you've carefully reviewed the suggestions.
- You may find the suggestions in this PR Guide useful.
- Your response may trigger a notification (depending on the reviewer's settings), helping ensure they’re aware of the updates you’ve made.- Replace the "Reviewed" label by a "Needs review" label
- Without this label, the reviewer would not know if your changes is ready to be reviewed.
Luro91
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
CYF-1039
This PR completes all the Sprint 2 exercises for the JavaScript Fundamentals module.
I agree to follow the code of conduct for this organisation