Skip to content

London | 26-ITP-SEP | Carol Nassuna | Sprint 1 | Form-Controls #1517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Mugs3 wants to merge 5 commits into
base: main
Choose a base branch
from
Open

London | 26-ITP-SEP | Carol Nassuna | Sprint 1 | Form-Controls #1517

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6143696
I have updated the index file to match the requirements of Tshirts order
Mugs3 Sep 13, 2026
78bef9c
Have added the css file
Mugs3 Sep 13, 2026
384c503
revisited and fixed all issues raised by the reviewer
Mugs3 Sep 14, 2026
76b166f
formatted both documents and change form method to get
Mugs3 Sep 15, 2026
c52542a
removed from method from index file
Mugs3 Sep 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 43 additions & 5 deletions Form-Controls/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,49 @@
<h1>Product Pick</h1>
</header>
<main>
<form>
<!-- write your html here-->
<!--
try writing out the requirements first as comments
this will also help you fill in your PR message later-->
<form action="order" method="post">

@abdishakoor-dev abdishakoor-dev Sep 14, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The task says "Do not write a form action for this project". What happens on the deploy preview when you fill the form in correctly and press Place Order?

@abdishakoor-dev abdishakoor-dev Sep 14, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Action gone. One thing left on this line, see the new comment.

<div>
<label for="CustomerName">Customer Name:</label>
<input type="text" id="CustomerName" name="CustomerName" required>

@abdishakoor-dev abdishakoor-dev Sep 14, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

required only stops the field being empty. Type two spaces and it passes. The README gives you a regex for "at least two non-space characters". Which attribute does it go in?

@abdishakoor-dev abdishakoor-dev Sep 14, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, and two spaces are rejected now. Good.

</div>
<div>
<label for="CustomerNumber">Customer Number:</label>
<input type="number" id="CustomerNumber" name="CustomerNumber" required>

@abdishakoor-dev abdishakoor-dev Sep 14, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where in the task is a customer number asked for? Every extra required field is one more thing the customer has to get right before they can order.

@abdishakoor-dev abdishakoor-dev Sep 14, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed, good.

</div>
<div>
<label for="CustomerEmail">Customer Email:</label>
<input
type="email"
id="CustomerEmail"
name="CustomerEmail"
required
pattern="[a-zA-Z0-9._%+-]+@[a-zA-Z0-9.-]+\.[a-zA-Z]{2,}"
title="Enter an email address such as name@example.com"
>
</div>
<div>
<label for="T-ShirtsColor">T-Shirt Color:</label>
<select id="T-ShirtsColor" name="T-ShirtsColor" required>
<option value="Red">Red</option>

@abdishakoor-dev abdishakoor-dev Sep 14, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Red is selected as soon as the page loads, so required has nothing to check. Read the validator's message for this line. What does it say the first option needs? Same for the size select on line 46.

@abdishakoor-dev abdishakoor-dev Sep 14, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both dropdowns fixed. Good.

<option value="Blue">Blue</option>
<option value="Green">Green</option>
</select>
</div>
<div>
<label for="T-ShirtsSize">T-Shirt Size:</label>
<select id="T-ShirtsSize" name="T-ShirtsSize" required>
<option value="XS">XS</option>
<option value="S">S</option>
<option value="M">M</option>
<option value="L">L</option>
<option value="XL">XL</option>
<option value="XXL">XXL</option>
</select>
</div>
</div>

@abdishakoor-dev abdishakoor-dev Sep 14, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which <div> is this closing? Count the opening and closing divs above it.

@abdishakoor-dev abdishakoor-dev Sep 14, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

<div>
<button type="submit">Place Order</button>
</div>
</form>
</main>
<footer>
Expand Down
23 changes: 23 additions & 0 deletions Form-Controls/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@

form > div {
margin-bottom: 1em;
}

label {
font-weight: bold;
}

button {
background-color: #4CAF50;
color: black;
font-weight: bold;
padding: 10px 20px;
border: none;
border-radius: 4px;
cursor: pointer;
}

button:hover {
background-color: #45a049;
}

Loading