Skip to content

London | 26-ITP-SEP | Abdennour Hachemi | Sprint 1 | form-controls #1503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AbdennourHachemi wants to merge 12 commits into
base: main
Choose a base branch
from
Open

London | 26-ITP-SEP | Abdennour Hachemi | Sprint 1 | form-controls #1503

Show file tree
Hide file tree
Changes from 11 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
30d9e25
start working on form
AbdennourHachemi Sep 8, 2026
e05cec1
adding CSS file and updating the index.html file
AbdennourHachemi Sep 11, 2026
cd10040
corecting typos and making adding attribute name to size radio button…
AbdennourHachemi Sep 11, 2026
4ac2403
formatting html file
AbdennourHachemi Sep 11, 2026
b0acd57
fixed some accessiblity issues
AbdennourHachemi Sep 11, 2026
bba3065
update files
AbdennourHachemi Sep 14, 2026
5923885
update files
AbdennourHachemi Sep 14, 2026
e64b174
fixing issues raised in the PR review
AbdennourHachemi Sep 14, 2026
57d7ed9
testing
AbdennourHachemi Sep 14, 2026
8161e1b
updating css file
AbdennourHachemi Sep 15, 2026
8a13945
Remove broken submodule
AbdennourHachemi Sep 15, 2026
d62854f
Fixing latest issues
AbdennourHachemi Sep 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
105 changes: 97 additions & 8 deletions Form-Controls/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,27 +1,116 @@
<!DOCTYPE html>
<!doctype html>
<html lang="en">
<head>
<meta charset="utf-8" />
<meta http-equiv="X-UA-Compatible" content="IE=edge" />
<title>My form exercise</title>
<meta name="description" content="" />
<meta name="description" content="Order form" />
<meta name="viewport" content="width=device-width, initial-scale=1" />
<link rel="stylesheet" href="styles.css" />
</head>

<body>
<header>
<h1>Product Pick</h1>
</header>
<main>
<form>
<!-- write your html here-->
<!--
try writing out the requirements first as comments
this will also help you fill in your PR message later-->
<div id="fn">
<label for="fname">Please Enter your name:</label>
<input
type="text"
id="fname"
name="fname"
pattern=".*\S.*\S.*"
required
/>
<br />
</div>

<div id="em">
<label for="email">Please Enter your Email:</label>
<input type="email" id="email" required /><br />
</div>
<div class="colorSelection">
<label for="colorOption">Please pick a color:</label> <br />

@abdishakoor-dev abdishakoor-dev Sep 15, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no element with id="colorOption", so this label labels nothing, and the same on line 62. A <label> attaches to one control. For a group of radios you want the element that wraps the group and takes a caption. What is it called?

<div class="colorOption">
<label for="blueOption">Blue</label>
<div class="square" id="blueOptions">
<input type="radio" name="color" id="blueOption" value="blue" />
</div>
</div>
<div class="colorOption">
<label for="greenOption">Green</label>
<div class="square" id="greenOptions">
<input type="radio" name="color" id="greenOption" value="green" />
</div>
</div>
<div class="colorOption">
<label for="redOption">Red</label>
<div class="square" id="redOptions">
<input
type="radio"
name="color"
id="redOption"
value="red"
required
/>
</div>
</div>
</div>
<div id="sizediv">
<label for="sizeOption">Please select the t-shirt size:</label> <br />
<div class="colorSelection">
<div class="sizeOption">
<label for="xs">XS</label>
<div>
<input type="radio" name="size" value="xs" id="xs" required />
</div>
</div>
<div class="sizeOption">
<label for="s">S</label>
<div>
<input type="radio" name="size" id="s" value="s" required />
</div>
</div>
<div class="sizeOption">
<label for="m">M</label>
<div>
<input type="radio" name="size" id="m" value="m" required />
</div>
</div>
<div class="sizeOption">
<label for="l">L</label>
<div>
<input type="radio" id="l" name="size" value="l" required />
</div>
</div>
<div class="sizeOption">
<label for="xl">XL</label>
<div>
<input type="radio" id="xl" name="size" value="xl" required />
</div>
</div>
<div class="sizeOption">
<label for="sizexxl">XXL</label>
<div>
<input
type="radio"
id="sizexxl"
name="size"
value="xxl"
required
/>
</div>
</div>
</div>
</div>
<input type="submit" value="Submit" />
</form>
</main>

<footer>
<!-- change to your name-->
<p>By HOMEWORK SOLUTION</p>
<h5>By Abdennour Hachemi</h5>
Comment thread
AbdennourHachemi marked this conversation as resolved.
Outdated
</footer>
</body>
</html>
66 changes: 66 additions & 0 deletions Form-Controls/styles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,66 @@
.colorSelection {
display: flex;
gap: 20px;
margin-left: 20px;
margin-top: 20px;
}

.colorOption {
display: flex;
flex-direction: column;
align-items: center;
}

.square {
height: 25px;
width: 25px;
}

#blueOptions {
background-color: #180fcb;
}

#greenOptions {
background-color: green;
}

#redOptions {
background-color: red;
}

#sizediv {
margin: 20px 20px;
}

#fn,
#sn,
#em {
margin: 20px 20px;
}

form

{
padding-top: 2%;
margin-right: 50%;
margin-left: 25%;
background-color: bisque;
}

h1,h5{
margin-left: 30%;
}

button[type="submit"],
input[type="submit"] {
padding: 10px 20px;
margin-left: 35%;
font-size: 1rem;
font-family: inherit;
color: #fff;
background-color: #2563eb;
border: none;
border-radius: 6px;
cursor: pointer;
transition: background-color 0.15s ease;
}
Loading