Repository navigation
London | 26-ITP-SEP | Sakiya Mayow | Sprint 1 | Form Controls #1500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
zakiaao-tech
wants to merge
12
commits into
CodeYourFuture:main
Choose a base branch
from
zakiaao-tech:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 8 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
a9b5770
Initial commit
zakiaao-tech 5c1e178
Added name and email validation to form in index.html
zakiaao-tech f9437e6
Added colour, size for validation to form in index.html
zakiaao-tech 6a476a1
Changed label and removed Last name and <legend>
zakiaao-tech 7db0e90
Removed submit button from email
zakiaao-tech 54ded4f
Removed spaces in id and name
zakiaao-tech 98961ad
left one submit button at the end and removed unnecessary spaces
zakiaao-tech 43145a0
Ran prettier to format document
zakiaao-tech 0dff25d
Removed trailing slash on br and regex, added =" to regex as required…
zakiaao-tech 39bfc0d
Made sure that the for on the labels is matching
zakiaao-tech 9e4795c
cleaned up
zakiaao-tech f95b8bd
Fixed / > endings and x ticking boxes in README checklist
zakiaao-tech File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| <!DOCTYPE html> | ||
| <!doctype html> | ||
| <html lang="en"> | ||
| <head> | ||
| <meta charset="utf-8" /> | ||
|
|
@@ -13,15 +13,51 @@ <h1>Product Pick</h1> | |
| </header> | ||
| <main> | ||
| <form> | ||
| <!-- write your html here--> | ||
| <!-- | ||
| try writing out the requirements first as comments | ||
| this will also help you fill in your PR message later--> | ||
| <div> | ||
| <label for="fullname">Full name:</label> | ||
| <input | ||
| type="text" | ||
| id="fullname" | ||
| name="Fullname" | ||
| required | ||
| .*\S.*\S.* | ||
| /> | ||
| <br /> | ||
| </div> | ||
|
|
||
| <div> | ||
| <label for="email">Email:</label> | ||
| <input type="email" name="email" id="email" required /> | ||
| </div> | ||
|
|
||
| <div> | ||
| <label for="T-shirt colour">Select one T-shirt colour:</label> | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
| <select name="T-shirt-colour" id="T-shirt-colour" required> | ||
| <option value="">Choose one colour</option> | ||
| <option>Black</option> | ||
| <option>Navy blue</option> | ||
| <option>Grey</option> | ||
| </select> | ||
| </div> | ||
|
|
||
| <div> | ||
| <label for="T-shirt Size">Select one size:</label> | ||
| <select name="T-shirt-Size" id="T-shirt-Size" required> | ||
| <option value="">Choose one size</option> | ||
| <option>XS</option> | ||
| <option>S</option> | ||
| <option>M</option> | ||
| <option>L</option> | ||
| <option>XL</option> | ||
| <option>XXL</option> | ||
| </select> | ||
| </div> | ||
|
|
||
| <button type="Submit">Submit</button> | ||
| </form> | ||
| </main> | ||
| <footer> | ||
| <!-- change to your name--> | ||
| <p>By HOMEWORK SOLUTION</p> | ||
| <p>By Sakiya Mayow</p> | ||
| </footer> | ||
| </body> | ||
| </html> | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still on its own here. Look at how
requiredon the line above is written, and howtype="text"is written. The regex needs to be written the same way, as the value of the attribute the README tip names.