Skip to content

London | 26-ITP-Sep | Shirin Panahian | Sprint 1| Form Controls #1496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shirinpanahian wants to merge 10 commits into
base: main
Choose a base branch
from
Open

London | 26-ITP-Sep | Shirin Panahian | Sprint 1| Form Controls #1496

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
e44425b
add input for name and email
shirinpanahian Sep 10, 2026
719578f
add select option for colour
shirinpanahian Sep 10, 2026
dd8d708
add select option for size
shirinpanahian Sep 10, 2026
bb6df86
add my name
shirinpanahian Sep 10, 2026
ee957cb
Add submit button
shirinpanahian Sep 10, 2026
632ad1a
change input name
shirinpanahian Sep 10, 2026
e2b259c
add css file
shirinpanahian Sep 10, 2026
ae5aab4
correct paddind
shirinpanahian Sep 14, 2026
f208c91
use format prettier
shirinpanahian Sep 14, 2026
3f84f50
delete comment on line 52
shirinpanahian Sep 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 34 additions & 5 deletions Form-Controls/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,22 +6,51 @@
<title>My form exercise</title>
<meta name="description" content="" />
<meta name="viewport" content="width=device-width, initial-scale=1" />
<link rel="stylesheet" href="style.css" />
</head>
<body>
<header>
<h1>Product Pick</h1>
</header>
<main>
<form>
<!-- write your html here-->
<!--
try writing out the requirements first as comments
this will also help you fill in your PR message later-->
<div>
<label for="name">Name</label>
<input type="text" id="name" name="name" required pattern=".*\S.*\S.*"/>
</div>
<div>
<label for="email">Email</label>
<input type="email" id="email" name="email" required />
</div>
<div>
<label for="color">Choose T-shirt color</label>
<select id="color" name="color" required>
<option value="">Select a color</option>
<option value="red">Red</option>
<option value="green">Green</option>
<option value="blue">Blue</option>
</select>
</div>
<div>
<label for="size">Size</label>
<select id="size" name="size" required>
<option value="">Choose a size</option>
<option value="XS">XS</option>
<option value="S">S</option>
<option value="M">M</option>
<option value="L">L</option>
<option value="XL">XL</option>
<option value="XXL">XXL</option>
</select>
</div>
<div>
<button type="submit">Submit</button>
</div>
</form>
</main>
<footer>
<!-- change to your name-->

@abdishakoor-dev abdishakoor-dev Sep 14, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment was an instruction from the starter file. Now you've done it, it can go.

@shirinpanahian shirinpanahian Sep 14, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I’ve fixed the formatting in both files using Prettier and removed the starter comment as requested. I’ve also committed and pushed the changes. Please have another look when you have a chance. Thank you!

@abdishakoor-dev abdishakoor-dev Sep 14, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seen, thanks. Marking it Complete.

<p>By HOMEWORK SOLUTION</p>
<p>By Shirin Panahian</p>
</footer>
</body>
</html>
13 changes: 13 additions & 0 deletions Form-Controls/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
input,
select,
button{
min-height: 40px;
padding: 10px;
font-size: 16px;
}
button{
padding: 12px,24px;

@abdishakoor-dev abdishakoor-dev Sep 14, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a comma between the two values, which isn't valid CSS, so the browser drops this rule and the button keeps the 10px padding from the rule above. What separates values in a shorthand property?

@shirinpanahian shirinpanahian Sep 14, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I corrected it. In CSS shorthand properties, values are separated by spaces, not commas.

@abdishakoor-dev abdishakoor-dev Sep 14, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct, and the button now gets its padding.

}
form > div{
margin-bottom: 16px;
}
Loading