Skip to content

London | 26-ITP-Sept | Fung Nin Lee | Sprint 1 | Forms Control #1484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
leerogerfn wants to merge 22 commits into
base: main
Choose a base branch
from
+64 −26
Open

London | 26-ITP-Sept | Fung Nin Lee | Sprint 1 | Forms Control #1484

Changes from 14 commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
3acf9bd
initial setup
leerogerfn Sep 8, 2026
4ea47cd
submit form requirements.
leerogerfn Sep 8, 2026
b23155b
added fieldset for the form
leerogerfn Sep 9, 2026
56ce344
added customer name
leerogerfn Sep 9, 2026
8eebedc
added emal address
leerogerfn Sep 9, 2026
f81e814
added color with 3 options
leerogerfn Sep 9, 2026
00d9593
added size for 6 options
leerogerfn Sep 9, 2026
b71b7df
added submit button
leerogerfn Sep 9, 2026
7a2fe70
final version
leerogerfn Sep 9, 2026
b50f040
removed fieldset and chnaged code of header.
leerogerfn Sep 12, 2026
e4c0e3e
set required for all questions in the form.
leerogerfn Sep 12, 2026
4a75ef1
removed unnecessary paragraph tags for cleaner form layout.
leerogerfn Sep 12, 2026
a53022c
fixed problem of reminder still come out even name submission fulfill…
leerogerfn Sep 12, 2026
5a42135
added <br> to seperate different parts of form.
leerogerfn Sep 12, 2026
f3a35c6
deleted div open code in line 24.
leerogerfn Sep 14, 2026
37378b4
required attributes to options. Use fieldset for color group radio bu…
leerogerfn Sep 14, 2026
028040f
removed empty p in line 53.
leerogerfn Sep 14, 2026
58c127f
removed HOMEWORK SOLUTION in line 62.
leerogerfn Sep 14, 2026
a8ca697
moved header to body elements.
leerogerfn Sep 14, 2026
deea624
added br in line 50.
leerogerfn Sep 14, 2026
dfe5ad2
fixed the default placeholder options in line 40.
leerogerfn Sep 14, 2026
3401c11
Formatting
leerogerfn Sep 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
66 changes: 52 additions & 14 deletions Form-Controls/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,24 +4,62 @@
<meta charset="utf-8" />
<meta http-equiv="X-UA-Compatible" content="IE=edge" />
<title>My form exercise</title>
<header><h1>Product Pick</h1></header>

@abdishakoor-dev abdishakoor-dev Sep 14, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is inside <head>. Which part of the page does <head> describe, and where should something the user sees go? The starter file had this right.

@abdishakoor-dev abdishakoor-dev Sep 14, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

<meta name="description" content="" />
<meta name="viewport" content="width=device-width, initial-scale=1" />
</head>
<body>
<header>
<h1>Product Pick</h1>
</header>



<main>
<form>
<!-- write your html here-->
<!--
try writing out the requirements first as comments
this will also help you fill in your PR message later-->
</form>
</main>
<footer>
<!-- change to your name-->
<p>By HOMEWORK SOLUTION</p>
</footer>
</body>
<label for="name">Customer Name</label>
<input type="text" id="name" name="name" pattern=".*\S.*\S.*" title="You must enter at least two characters" required />
<div>
<label for="email">Email</label>
<input type="email" id="email" name="email" required>
</div>

<div>

@abdishakoor-dev abdishakoor-dev Sep 14, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This <div> is never closed. Count the opening and closing divs from here to line 51. That's why the validator stops and Prettier can't format the file.

@abdishakoor-dev abdishakoor-dev Sep 14, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, and the validator is clean now.

<br>
Color

@abdishakoor-dev abdishakoor-dev Sep 14, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loose text as a heading for the radios. Hammad's fieldset link was about this. What does the MDN page from the prep on structuring a form use to group radio buttons and caption them?

@abdishakoor-dev abdishakoor-dev Sep 14, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's the one. Fieldset and legend, done.

<div>
<label for="red">Red</label>
<input type="radio" id="red" name="color" value="red" required>
</div>
<div>
<label for="blue">Blue</label>
<input type="radio" id="blue" name="color" value="blue" required>
</div>
<div>
<label for="green">Green</label>
<input type="radio" id="green" name="color" value="green" required>
</div>
<br>
<div>
<label for="size">Size</label>
<select name="size" id="size" required>
<option disabled hidden selected required value="">Select One</option>

@abdishakoor-dev abdishakoor-dev Sep 14, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

required isn't an attribute an <option> can have. The one on the <select> on line 42 is the one doing the work, so this can go.

@abdishakoor-dev abdishakoor-dev Sep 14, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

<option value="xs">XS</option>
<option value="s">S</option>
<option value="m">M</option>
<option value="l">L</option>
<option value="xl">XL</option>
<option value="xxl">XXL</option>
</select>
</div>
<p></p>

@abdishakoor-dev abdishakoor-dev Sep 14, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hammad asked about the empty <p> and there's still one here. What is it for?

@abdishakoor-dev abdishakoor-dev Sep 14, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gone, good.

<button type="submit">submit</button>
</form>
</main>




<footer>
<p>By Fung Nin Lee (Roger) HOMEWORK SOLUTION</p>

@abdishakoor-dev abdishakoor-dev Sep 14, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HOMEWORK SOLUTION should have gone when you put your name in.

@leerogerfn leerogerfn Sep 14, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Abdi. Thank you for your comments. Could you feel free to check if it is OK now?

@abdishakoor-dev abdishakoor-dev Sep 14, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, all the structure points are done. One thing left, formatting, see the main comment.

</footer>

</body>
</html>
Loading