Skip to content

London | 2-ITP-Sept | Hugh Mills| Sprint 1 | Form Controls #1473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
HM-127BTY wants to merge 8 commits into
base: main
Choose a base branch
from
Open

London | 2-ITP-Sept | Hugh Mills| Sprint 1 | Form Controls #1473

Changes from 5 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
1a80e0b
Started by adding info needed and putting <div> for each request of info
HM-127BTY Sep 7, 2026
b14a6c9
Added type for email aswell as placeholders and pattern for "name"
HM-127BTY Sep 7, 2026
2e39c78
Added labels for the colours, Added required to each current input
HM-127BTY Sep 7, 2026
2c1de1d
fixed errors in the code, syntax was wrong in parts.
HM-127BTY Sep 7, 2026
06eac62
Cleaned up by removing my comments and checking code for errors.
HM-127BTY Sep 7, 2026
c6f3d57
added "id=" to the labels and inputs and fixed errors found such as v…
HM-127BTY Sep 10, 2026
e726ddb
removed a . that was in pattern=".*\S.*\S.*" , it was pattern=".*\S.*…
HM-127BTY Sep 11, 2026
a6e1983
Added <br> to all inputs and seperated the Submit and Reset with ----
HM-127BTY Sep 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 38 additions & 1 deletion Form-Controls/index.html
View file
Open in desktop

@Luro91 Luro91 Sep 10, 2026 •
edited
Loading

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The lighthouse Accessibility score is below 100. How can you achieve 100?

@HM-127BTY HM-127BTY Sep 10, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, i didn't have the labels matching id's on it, fixed that now.

@Luro91 Luro91 Sep 11, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see a different problem in lighthouse now: "Touch targets with sufficient size and spacing help users who may have difficulty targeting small controls to activate the targets"

@HM-127BTY HM-127BTY Sep 11, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed this by spacing them out with
and spaced out the submit and reset buttons with text ---

Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,43 @@ <h1>Product Pick</h1>
</header>
<main>
<form>
<div>
<label for="name">Name:</label>
<input type="text" id="name" placeholder="Hugh Mills" pattern=".*\S.*\S.*." required>

@Luro91 Luro91 Sep 10, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The validation does not allow special characters like the German ä,ü,ö or Russian ед

@HM-127BTY HM-127BTY Sep 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't use any of those, and I can't see any text input that matches those, can you point it out for me?

@Luro91 Luro91 Sep 11, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I enter this string Är as name then it does not pass the validation although it is 2 characters

@HM-127BTY HM-127BTY Sep 11, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Är would not work as it is one word when the input needs at least 2, it does also accept special characters as inputting "Är Är" works.

When checking it if "Ä r" it wasn't taking that but was taking "Ä Ä", checked it and seen that the pattern=".\S.\S.*." had an extra . by mistake and removed that.

</div>
<div>
<label for="email">Email:</label>
<input type="email" id="email" placeholder="hugh.mills@myemail.com" required>
</div>
<div>
Colour- Please Select one:<br>
<label for="white">White</label>
<input type="radio" name="colour" value="white" required>
<label for="black">Black</label>
<input type="radio" name="colour" value="black">
<label for="blue">Blue</label>
<input type="radio" name="colour" value="white">
</div>
<div>
Size - Please select one:<br>
<label for="size">XS:</label>
<input type="radio" name="size" value="xs" required>
<label for="size">S:</label>
<input type="radio" name="size" value="s">
<label for="size">M:</label>
<input type="radio" name="size" value="m"><br>
<label for="size">L:</label>
<input type="radio" name="size" value="l">
<label for="size">XL:</label>
<input type="radio" name="size" value="xl">
<label for="size">XXL:</label>
<input type="radio" name="size" value="xxl">

@Luro91 Luro91 Sep 10, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: I would change the form types. Radio buttons are good if there are not to many options to choose from. Space on a web page is precious and for inputs with a lot of options, a dropdown can save a lot of space. (You don't need to change anything. This is just an information on the different input types)

@HM-127BTY HM-127BTY Sep 10, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestion, ill have a look into that

</div>
<div>
<input type="submit">
<input type="reset">
</div>

<!-- write your html here-->
<!--
try writing out the requirements first as comments
Expand All @@ -21,7 +58,7 @@ <h1>Product Pick</h1>
</main>
<footer>
<!-- change to your name-->
<p>By HOMEWORK SOLUTION</p>
<p>By Hugh Mills</p>
</footer>
</body>
</html>
Loading