Repository navigation
Birmingham | 26-Jul-SDC | Merve Reis | Sprint 3 | Middleware CYF-1165 #123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mervereis
wants to merge
9
commits into
CodeYourFuture:main
Choose a base branch
from
mervereis:sprint3-middleware-exercises
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
1c935a0
feat: initialize backend and frontend for group chat application
mervereis 649db14
feat: add Dockerfile for backend setup
mervereis 39df628
feat: implement long-polling for message retrieval and update message…
mervereis c22864b
fix: update CORS configuration to remove unused origins
mervereis 835930f
fix: update server and client URLs for deployment
mervereis d164cad
fix: improve message filtering and update handling in polling function
mervereis f000da2
feat: initialize backend and frontend for chat application
mervereis 3cb67fb
chore: add package.json for middleware-exercises with express dependency
mervereis 8eda15a
Remove unnecessary backend and frontend
mervereis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| node_modules |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,72 @@ | ||
| const express = require("express"); | ||
|
|
||
| const app = express(); | ||
| const PORT = 3000; | ||
|
|
||
| // Middleware 1:check X-Username header | ||
| function usernameMiddleware(req, res, next) { | ||
| const username = req.get("X-Username"); | ||
|
|
||
| if (username) { | ||
| req.username = username; | ||
| } else { | ||
| req.username = null; | ||
| } | ||
|
|
||
| next(); | ||
| } | ||
|
|
||
| // Middleware 2: parse and validate JSON array | ||
| function bodyMiddleware(req, res, next) { | ||
| let body = ""; | ||
|
|
||
| req.on("data", (chunk) => { | ||
| body += chunk; | ||
| }); | ||
|
|
||
| req.on("end", () => { | ||
| try { | ||
| const parsedBody = JSON.parse(body); | ||
|
|
||
| if (!Array.isArray(parsedBody)) { | ||
| return res.status(400).send("Request body must be a JSON array."); | ||
| } | ||
|
|
||
| if (!parsedBody.every((item) => typeof item === "string")) { | ||
| return res.status(400).send("Array must contain only strings."); | ||
| } | ||
|
|
||
| req.body = parsedBody; | ||
| next(); | ||
| } catch (error) { | ||
| res.status(400).send("Request body must be valid JSON."); | ||
| } | ||
| }); | ||
| } | ||
|
|
||
| app.use(usernameMiddleware); | ||
| app.use(bodyMiddleware); | ||
|
|
||
| app.post("/", (req, res) => { | ||
| const subjects = req.body; | ||
|
|
||
| if (req.username) { | ||
| res.send( | ||
| `You are authenticated as ${req.username}.\n\n` + | ||
| `You have requested information about ${subjects.length} ` + | ||
| `${subjects.length === 1 ? "subject" : "subjects"}` + | ||
| `${subjects.length > 0 ? ": " + subjects.join(", ") : ""}.`, | ||
| ); | ||
| } else { | ||
| res.send( | ||
| `You are not authenticated.\n\n` + | ||
| `You have requested information about ${subjects.length} ` + | ||
| `${subjects.length === 1 ? "subject" : "subjects"}` + | ||
| `${subjects.length > 0 ? ": " + subjects.join(", ") : ""}.`, | ||
| ); | ||
| } | ||
| }); | ||
|
|
||
| app.listen(PORT, () => { | ||
| console.log(`Server running on http://localhost:${PORT}`); | ||
| }); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| import express from "express"; | ||
|
|
||
| const app = express(); | ||
|
|
||
| function usernameMiddleware(req, res, next) { | ||
| const username = req.get("X-Username"); | ||
|
|
||
| if (username) { | ||
| req.username = username; | ||
| } else { | ||
| req.username = null; | ||
| } | ||
|
|
||
| next(); | ||
| } | ||
|
|
||
| app.use(express.json()); | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Does express.json() do all of the checks you did in your original code? |
||
| app.use(usernameMiddleware); | ||
|
|
||
| app.post("/", (req, res) => { | ||
| const subjects = req.body; | ||
|
|
||
| if (req.username) { | ||
| res.send( | ||
| `You are authenticated as ${req.username}.\n\n` + | ||
| `You have requested information about ${subjects.length} ` + | ||
| `${subjects.length === 1 ? "subject" : "subjects"}` + | ||
| `${subjects.length > 0 ? `: ${subjects.join(", ")}` : ""}.`, | ||
| ); | ||
| } else { | ||
| res.send( | ||
| `You are not authenticated.\n\n` + | ||
| `You have requested information about ${subjects.length} ` + | ||
| `${subjects.length === 1 ? "subject" : "subjects"}` + | ||
| `${subjects.length > 0 ? `: ${subjects.join(", ")}` : ""}.`, | ||
| ); | ||
| } | ||
| }); | ||
|
|
||
| app.listen(3000, () => { | ||
| console.log("Server running on http://localhost:3000"); | ||
| }); | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given these messages are quite similar, could you rework the if block to reduce the code duplication?