Repository navigation
London | 26-Jul-SDC | Roman Sanaye | Sprint 3 | Middleware CYF-1165 - #120
RomanSanaye wants to merge 3 commits into
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
LonMcGregor
left a comment
There was a problem hiding this comment.
Apologies for the delay in this review.
Does this meet the spec set out in the prep? We're looking for some middleware that handles the JSON, and that can check a username. Do you want to have another look?
|
Your PR didn't include a Task ID in its description. Make sure you have put the correct Task ID in its description. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above. |
1 similar comment
|
Your PR didn't include a Task ID in its description. Make sure you have put the correct Task ID in its description. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above. |
Learners, PR Template
Self checklist
Changelist
Added two new directories demonstrating Express middleware:
custom-middlewarecontains an Express application with two custom-written middlewares.off-the-shelf-middlewarereplaces one custom middleware with the third-partycorsmiddleware.Both applications have been tested locally.