Skip to content

London | 26-Jul-SDC | Roman Sanaye | Sprint 3 | Middleware CYF-1165 - #120

Open
RomanSanaye wants to merge 3 commits into
CodeYourFuture:mainfrom
RomanSanaye:middleware
Open

RomanSanaye wants to merge 3 commits into
CodeYourFuture:mainfrom
RomanSanaye:middleware

Conversation

@RomanSanaye

@RomanSanaye RomanSanaye commented Sep 8, 2026 •

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes

Changelist

Added two new directories demonstrating Express middleware:

custom-middleware contains an Express application with two custom-written middlewares.
off-the-shelf-middleware replaces one custom middleware with the third-party cors middleware.

Both applications have been tested locally.

@github-actions

This comment has been minimized.

@RomanSanaye RomanSanaye added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 8, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 8, 2026
@RomanSanaye RomanSanaye added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 8, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 8, 2026
@github-actions

This comment has been minimized.

@RomanSanaye RomanSanaye changed the title London | 26-Jul-SDC | Roman Sanaye | Sprint 1 | Middleware CYF-1165 London | 26-Jul-SDC | Roman Sanaye | Sprint 3 | Middleware CYF-1165 Sep 8, 2026
@RomanSanaye RomanSanaye added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 8, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 8, 2026
@RomanSanaye RomanSanaye added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 8, 2026

@LonMcGregor LonMcGregor left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the delay in this review.

Does this meet the spec set out in the prep? We're looking for some middleware that handles the JSON, and that can check a username. Do you want to have another look?

@LonMcGregor LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 7, 2026
@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown

Your PR didn't include a Task ID in its description.

Make sure you have put the correct Task ID in its description.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

1 similar comment
@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown

Your PR didn't include a Task ID in its description.

Make sure you have put the correct Task ID in its description.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Reviewed Volunteer to add when completing a review with trainee action still to take.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants