London | 26-ITP-May | Gideon Defar | sprint 1 | Coursework

[gideondefar]

Self checklist

• I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
• My changes meet the requirements of the task
• I have tested my changes
• My changes follow the style guide

Changelist

Completed all mandatory Sprint 1 exercises. The optional Stretch exercise was not completed due to time constraints.

[hackertainment]

I think your code is well organised and test cases are also clearly written. Keep it up. :-)

[gideondefar]

I think your code is well organised and test cases are also clearly written. Keep it up. :-)

Thanks for the positive feedback but the label was changed to "reviewed" is it intensional or its made by accident?

[abdishakoor-dev]

Two things to sort before this can be marked complete:

1. The refactor exercise hasn't been started

Sprint-1/refactor/includes.js line 1 says:

// Refactor the implementation of includes to use a for...of loop

The function still uses the original indexed for (let index = 0; index < list.length; index++) loop, so there's no refactoring done in this file yet. The only change in the diff is the trailing newline.

2. The fix exercise: work in median.js, not median.test.js

median.test.js line 5 says:

// Fix the implementation of calculateMedian so it passes all tests

The test file is what needs to pass for this exercise, so leave it exactly as it was and change only median.js until the tests it already contains pass. At the moment the original tests have been replaced with a new set of tests, so the ones you were asked to pass aren't being run, so restore the original median.test.js please.

Hint: your first line in median.js is list = list.filter((item) => typeof item === "number" && !isNaN(item)); which assumes list is an array. What if it's NOT an array? What if a string or object or nothing is passed in? filter can only work with array? What do you need to do in those cases?

Everything in the implement folder (sum, max, dedupe) looks good, nice clean handling of the edge cases there.

[hackertainment]

I think your code is well organised and test cases are also clearly written. Keep it up. :-)

Thanks for the positive feedback but the label was changed to "reviewed" is it intensional or its made by accident?

There are two fixes (the second and third one) required as you scroll up a bit. I made comments directly with the corresponding lines of code. Thank you.

[gideondefar]

median.test.js line 5 says:

// Fix the implementation of calculateMedian so it passes all tests

@hackertainment I hope fixed and completed sprint 1 exercises.

[hackertainment]

https://github.com/CodeYourFuture/Module-Data-Groups/pull/1437/changes/BASE..99b017e656a5d1061c2dcf1bb81cc69aba5cd031#r3820288450
Please add test case for this one as well. thank you.

[gideondefar]

https://github.com/CodeYourFuture/Module-Data-Groups/pull/1437/changes/BASE..99b017e656a5d1061c2dcf1bb81cc69aba5cd031#r3820288450 Please add test case for this one as well. thank you.

@hackertainment added test cases and tested on the terminal thanks for the review.

[hackertainment]

There are two cases in the "ignores non-number values" suite and both are odd number of elements aftrer filtering. Maybe consider next time also have even number of elements after filtering. I will let you pass this time since this is just a minor issue and your other test cases have good coverage.

[hackertainment]

Missing test case for this one and please add it as well. Thank you.

[hackertainment]

please modify the for(...) loop into for(...of...) loop in the code below. Thank you.