chore: Ui corrections - #5
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (10)
📝 WalkthroughWalkthroughThis PR removes the NextGenie Chat Log doctype (JSON, client script, tests), adds a new Nextgenie Settings doctype with AI assistant configuration fields, renames the settings backend class, updates chat page UI with session deletion and navbar toggling, and adds session ownership authorization checks to backend chat endpoints. ChangesChat Log Removal and Settings Doctype
Chat Page UI and Session Security
Estimated code review effort: 3 (Moderate) | ~25 minutes Sequence Diagram(s)sequenceDiagram
participant User
participant nextgenie_js as nextgenie.js (Client)
participant Backend as nextgenie.py
participant DB as Genie Chat Session/Message
User->>nextgenie_js: Click delete button on history item
nextgenie_js->>User: frappe.confirm dialog
User->>nextgenie_js: Confirm deletion
nextgenie_js->>Backend: delete_session(id)
Backend->>Backend: _check_session_owner(session_id)
Backend->>DB: Delete Genie Chat Message rows
Backend->>DB: Delete Genie Chat Session
Backend-->>nextgenie_js: success payload
nextgenie_js->>nextgenie_js: Update local sessions list
alt deleted session was active
nextgenie_js->>Backend: load next session or create new
else
nextgenie_js->>nextgenie_js: Re-render history
end
Possibly related PRs
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary by CodeRabbit
New Features
Bug Fixes