spec(0.10.0): §4's probability is p(last | first n−1) among sequences of the entry's own length — "joint prob otherwise" withdrawn - #16
Merged
Conversation
… of the entry's own length — "joint prob otherwise" withdrawn The example comment was the field's only definition, and it was wrong at every ngram_size above 2: the reference producer has always emitted the conditional, and §13's ngram_delta.rate_changed reads the value as a transition rate, which a joint probability (a restatement of count) cannot be. A paragraph under §4 now defines it: count over the summed count of the window's counted sequences of the same length sharing the first n-1 ids, before the top_ngrams_size cut. Breaking by the letter, editor-merged under GOVERNANCE §2's 0.x rule; no schema change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
SPEC.md§4 definedbehavior.top_ngrams[].probabilityonly in the example's comment: "p(next | prev) for n=2; joint prob otherwise". This PR replaces that comment and adds a paragraph under §4:CHANGELOG.mdrecords it under 0.10.0 (still unreleased) › Changed, and the 0.10.0 headline lists it among the breaking items.Why
ngram_delta.rate_changedcompares the value across two windows as a transition rate. A joint value restates frequency, whichcountalready carries, sorate_changedwould move with any change in traffic mix, and one field would mean a different quantity at eachngram_size.top_ngramscan carry. It also corrects a reference-implementation defect: whentop_ngramsheld sequences of two lengths, the producer pooled them under one denominator. Only such documents move.Change class
Breaking by the letter: a producer that followed "joint" becomes non-conformant. Under
GOVERNANCE.md§2's 0.x rule (PR #15), the editor merges it with norfc:issue. No schema change: the field stays a number in [0, 1].conformance/metalog_validate.py --selftest: 31/31 fixtures pass.🤖 Generated with Claude Code