Remove the memory extra: it installed neo4j with nothing behind it - #36
Merged
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Takes option (a) Remove it from the issue — the smaller, safer change it recommends.
pyproject.toml: deleted thememoryextra (neo4j>=5.20) and removedmemoryfrom the self-referentialallaggregation. Nothing undergrapharc/importsneo4j, so the extra installed a driver and delivered no capability.uv.lock: regenerated —neo4jis gone from the graph and fromprovides-extras.README.md: the Memory section's closing note no longer advertises the dead extra; it now names the stores that actually exist (SQLiteMemoryStore, no extra needed;LadybugMemoryStorevia theladybugextra).ROADMAP.md(8.7): the "still names Neo4j with nothing importing it" note now records the removal; a future Neo4j-backed store would bring its own extra with it.No Neo4j store is implemented here, per the issue's explicit scope.
Verification
uv sync --all-extras --group devresolves cleanlyuv run pytest: 1641 passed, 12 deselected (live)uv run ruff check .: cleantests/test_packaging.py::test_the_all_extra_names_every_other_extrastays green with the extra removed from both placesFixes #3
🤖 Generated with Claude Code