Add a propose kind: the model authors from what the registry read - #30
Merged
Conversation
plan_docs could read and summarise but a goal ending "and then create a plan for merging them" was satisfied by the mechanical goal check without the proposal ever existing. The fourth kind closes that: its body hands the deterministic notes to the run's model and records the recommendation as `proposal (model-authored):` — the one body in this registry that speaks to a model, built per-run by build_registry(model) via the CLI's existing factory contract. Honesty at the edges: with no real model behind the run (None, or the planner's own ScriptedChatModel, whose replies a body must not consume) the note says authoring needs --model instead of pretending; a model call that raises becomes a note too, because the deterministic reads already in state are worth keeping when the proposal step cannot run. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the gap demonstrated live today:
plan "read the docs, summarise them and then create a plan for merging them"reachedgoal_metwith no merge plan anywhere — the mechanical goal check (≥3 notes) was satisfied by reading alone.proposeis the registry's one model-speaking kind: its body hands the notes the deterministic kinds collected to the run's model and appends the reply asproposal (model-authored): …. Wiring is the CLI's existing contract —build_registry(model)— so the same backend that plans also authors, with the two roles cleanly separable (the loop test drives a scripted planner whileproposeuses a real-model stand-in).Edge honesty, all tested:
Noneor the planner's ownScriptedChatModel(whose scripted replies a node body must not consume) yields a note saying authoring needs--model; a model call that raises becomes amodel call failednote rather than an execution failure, keeping the deterministic reads. The scripted chain now includesproposeso the free path shows the declining note; instance-name≠kind coverage extends to the new kind.Four new/extended tests; full suite green;
ruffclean; cookbook 07 updated.🤖 Generated with Claude Code