chore(balancer): pin to v1.1.7 tag and bump image off the dev build - #193
Open
TineoC wants to merge 1 commit into
Open
chore(balancer): pin to v1.1.7 tag and bump image off the dev build#193TineoC wants to merge 1 commit into
TineoC wants to merge 1 commit into
Conversation
The holosource was pinned to c88a4d8f, the balancer-main#507 merge SHA, with a note that no tag past v1.1.5 had been cut. v1.1.6 and v1.1.7 shipped 2026-07-14 and both contain that commit (c88a4d8f...v1.1.7 is ahead=41, behind=0), so the pin can move to a real tag. Manifest-neutral: the only deploy/ changes between c88a4d8f and v1.1.7 are gateway-listeners.yaml, httproute.yaml, the kustomizations and the README — none of which this repo projects. balancer/app/manifests.toml takes only namespace.yaml, deployment.yaml and service.yaml, all unchanged. The image tag was still 0.0.0-dev.20260211012449, a Feb 11 dev build months older than the manifests it ran under. Moves to 1.1.7 (verified published to ghcr) so the running image and the pinned source agree. Refs CodeForPhilly/balancer-main#526, CodeForPhilly#162
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the first two followups carried over from #162's closing comment, tracked in CodeForPhilly/balancer-main#526.
What changed
.holo/sources/balancer.toml—refmoves from the bare SHAc88a4d8f(the balancer-main#507 merge) torefs/tags/v1.1.7.The old comment said "no tag has been cut past v1.1.5 yet". That stopped being true on 2026-07-14. Both v1.1.6 and v1.1.7 contain the pinned commit:
balancer/app/kustomization.yaml— image0.0.0-dev.20260211012449→1.1.7. That dev build is from Feb 11, months older than the June manifests it has been running under.1.1.7is published (verified against ghcr's manifest endpoint).Why this is safe
The pin bump is manifest-neutral. Everything that changed under
deploy/betweenc88a4d8fandv1.1.7:balancer/app/manifests.tomlprojects onlynamespace.yaml,deployment.yamlandservice.yaml— none of those changed. Routing stays with this repo's_gateways/balancer.yaml; upstream'shttproute.yamlis still not projected, so there is no duplicate route.The image bump is the only behavioral change here, and it is the one worth eyes on.
Verification after deploy
kubectl -n balancer get pods→1/1 Running, no restartskubectl -n balancer get deploy balancer -o jsonpath='{.spec.template.spec.containers[0].image}'→...app:1.1.7curl -so /dev/null -w '%{http_code}' https://balancer.sandbox.k8s.phl.io/→200, same for/admin/login/kubectl -n cloudnative-pg get database balancer -o jsonpath='{.status.applied}'→ stilltrueNot in this PR
The third followup in that comment — "the old RDS instance is now unused, coordinate to spin it down" — should not be acted on. It is true for sandbox only.
cfp-live-clusterhas no cnpg, and production's sealedSQL_HOSThas not changed since 2025-12-06. See CodeForPhilly/balancer-main#526.