Repository navigation
Add OAuth2 flow for CiteDrive (replay of JabRef/jabref#14493) - #2
Open
Svilen-Stefanov wants to merge 114 commits into
Open
Svilen-Stefanov wants to merge 114 commits into
Svilen-Stefanov wants to merge 114 commits into
Conversation
A notification was easy to miss, so JabRef now asks and switches the server on. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018RuRpcKSiQEzrbZ1eWX7bx
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018RuRpcKSiQEzrbZ1eWX7bx
The browser was left with one bare line of text; it now shows what happened and that the work continues in JabRef. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018RuRpcKSiQEzrbZ1eWX7bx
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018RuRpcKSiQEzrbZ1eWX7bx
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018RuRpcKSiQEzrbZ1eWX7bx
The CiteDrive settings had no user interface: the tab holds them and takes further services later. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018RuRpcKSiQEzrbZ1eWX7bx
CiteDrive is opt-in: without it the File menu shows no CiteDrive entry. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018RuRpcKSiQEzrbZ1eWX7bx
# Conflicts: # jabgui/src/main/themes.jabref.org
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018RuRpcKSiQEzrbZ1eWX7bx
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018RuRpcKSiQEzrbZ1eWX7bx
….java Co-authored-by: Gareth Bilaney <gareth.bilaney@hhu.de>
# Conflicts: # .jbang/JabSrvLauncher.java
- Revert unrelated edits to .idea/checkstyle-idea.xml and CommonArchitectureTest - Remove CiteDrivePreferencesTest and ExternalStoragesTabViewModelTest: they only mirror the code under test - Explain in JavaDoc why OAuthSessionRegistryTest and CiteDrivePushTest exist - ServerCli: reuse the preferences instance, replace the TODO by an explanation of the fresh registry - Use StringUtil.isBlank for the keyring JSON check - Move "Enable HTTP server" next to the other HTTP server strings, separate the CiteDrive block - Order jbang DEPS alphabetically Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
The OAuth flow lives in jablib and only needs a way to show the login address and a running callback server, so jabsrv can log in without the GUI: it prints the address, waits for the browser to return to /callback, stores the refresh token in the keyring, and exits. The option refuses to start if the preferences' HTTP server port (where CiteDrive redirects the browser) differs from the port jabsrv listens on, or if the login would not be remembered between sessions. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
# Conflicts: # .jbang/JabSrvLauncher.java
Bind stored credentials and uploads to the issuing server. Reject insecure endpoints and discard stale authentication responses. Share refresh requests to avoid rotating-token reuse. Bound token network operations and preserve credentials after transient failures.
Launch the recording shell script directly rather than treating it as a macOS application bundle. Keep the complete URL assertion intact.
CodeBoarding reviewStatus: 10 changed components See the full change in CodeBoarding. Compared against the merge base: this branch is 2 commits behind graph LR
n_Core_Library_Logic["Core Library Logic"]
n_Desktop_User_Interface["Desktop User Interface"]
n_HTTP_Server_Service["HTTP Server Service"]
n_Command_Line_Toolkit["Command Line Toolkit"]
n_Language_Server_Service["Language Server Service"]
n_Test_and_Build_Support["Test and Build Support"]
n_Developer_Python_Scripts["Developer Python Scripts"]
n_Build_Logic_Conventions["Build Logic Conventions"]
n_Core_Library_Logic -- "delegates UI tasks and alerts" --> n_Desktop_User_Interface
n_Core_Library_Logic -- "invokes export service" --> n_Command_Line_Toolkit
n_Core_Library_Logic -- "references test support classes" --> n_Test_and_Build_Support
n_Desktop_User_Interface -- "configures and manipulates core entities in" --> n_Core_Library_Logic
n_Desktop_User_Interface -- "manages embedded HTTP server" --> n_HTTP_Server_Service
n_Desktop_User_Interface -- "manages language server lifecycle" --> n_Language_Server_Service
n_HTTP_Server_Service -- "reads core configurations and models from" --> n_Core_Library_Logic
n_HTTP_Server_Service -- "queries state and dispatches notifications to" --> n_Desktop_User_Interface
n_Command_Line_Toolkit -- "executes CLI commands via core logic" --> n_Core_Library_Logic
n_Command_Line_Toolkit -- "shares presentation formatters" --> n_Desktop_User_Interface
n_Language_Server_Service -- "uses core parsers and preferences" --> n_Core_Library_Logic
n_Language_Server_Service -- "dispatches commands to GUI handler" --> n_Desktop_User_Interface
n_Test_and_Build_Support -- "exercises parsers and models" --> n_Core_Library_Logic
classDef added fill:#1f883d,stroke:#0b5d23,color:#ffffff;
classDef modified fill:#bf8700,stroke:#7d4e00,color:#ffffff;
classDef deleted fill:#cf222e,stroke:#82071e,color:#ffffff,stroke-dasharray:5 3;
class n_Core_Library_Logic,n_Desktop_User_Interface,n_HTTP_Server_Service modified;
linkStyle 3,6,7 stroke:#7d4e00,stroke-width:2px;
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replay of JabRef#14493 inside CodeBoarding's fork, to review it with CodeBoarding.
011e240, unchanged.88cf41e, plus one commit that keeps only the CodeBoarding review workflow (JabRef's own CI is removed on this base branch).CodeBoarding/CodeBoarding-action@test/jabref-java25, which installs Core fromCodeBoarding/CodeBoarding@test/jabref-java25(Java 25 and JDT LS fixes, not yet released).🤖 Generated with Claude Code