Skip to content

Split DirectoryLibrarySynchronizer into collaborators (replay of JabRef/jabref-koppor#760) - #2

Open
Svilen-Stefanov wants to merge 16 commits into
cb-review/760-basefrom
cb-review/760
Open

Svilen-Stefanov wants to merge 16 commits into
cb-review/760-basefrom
cb-review/760

Conversation

@Svilen-Stefanov

Copy link
Copy Markdown

Replay of JabRef#760 inside CodeBoarding's fork, to review it with CodeBoarding.

  • Head: the PR's head commit 364cf8e, unchanged.
  • Base: the PR's merge base f2e9f62 (directory-rest-api), plus one commit that keeps only the CodeBoarding review workflow (JabRef's own CI is removed on this base branch).
  • The review runs CodeBoarding/CodeBoarding-action@test/jabref-java25, which installs Core from CodeBoarding/CodeBoarding@test/jabref-java25 (Java 25 and JDT LS fixes, not yet released).

🤖 Generated with Claude Code

koppor and others added 16 commits September 3, 2026 15:17
The synchronizer keeps the inbound direction and the lifecycle; SidecarWriteBack writes sidecars (including the pair rename), BibMirror maintains the .bib mirror and its merge-back, PendingWrites debounces and retries writes, and TrackedFiles holds the fingerprints and merge bases both directions share. Public API and behaviour are unchanged; the package gets its package-info.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Vr3E1Gg5DRU4LQDDVnhPys
Fixes the CI format check.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DDcHNMt9fPWnpYaHheFvry
Resolve the synchronizer split against the upstream resync.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DDcHNMt9fPWnpYaHheFvry
Upstream added a 0071 ADR after this stack claimed the number, so the
MADR duplicate-ID check failed.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01CajtxjcCEjS87f4hoTBTJD
@github-actions

github-actions Bot commented Nov 8, 2026 •

Copy link
Copy Markdown

CodeBoarding review

Status: 4 changed components

See the full change in CodeBoarding.

Compared against the merge base: this branch is 3 commits behind cb-review/760-base.

graph LR
    n_Core_Logic_and_Data_Model["Core Logic and Data Model"]
    n_Desktop_User_Interface["Desktop User Interface"]
    n_HTTP_and_Citation_Service["HTTP and Citation Service"]
    n_Command_Line_Toolkit["Command Line Toolkit"]
    n_Language_Server_Backend["Language Server Backend"]
    n_Build_and_Test_Utilities["Build and Test Utilities"]
    n_Auxiliary_Maintenance_Scripts["Auxiliary Maintenance Scripts"]
    n_Gradle_Build_Conventions["Gradle Build Conventions"]
    n_Core_Logic_and_Data_Model -- "schedules tasks and notifications via" --> n_Desktop_User_Interface
    n_Core_Logic_and_Data_Model -- "delegates export routines to" --> n_Command_Line_Toolkit
    n_Core_Logic_and_Data_Model -- "invokes test fixtures in" --> n_Build_and_Test_Utilities
    n_Desktop_User_Interface -- "orchestrates bibliographic operations through" --> n_Core_Logic_and_Data_Model
    n_Desktop_User_Interface -- "manages embedded server state of" --> n_HTTP_and_Citation_Service
    n_Desktop_User_Interface -- "controls language server lifecycle in" --> n_Language_Server_Backend
    n_HTTP_and_Citation_Service -- "accesses logic services and preferences" --> n_Core_Logic_and_Data_Model
    n_HTTP_and_Citation_Service -- "synchronizes selection state with" --> n_Desktop_User_Interface
    n_Command_Line_Toolkit -- "executes bibliographic operations using" --> n_Core_Logic_and_Data_Model
    n_Command_Line_Toolkit -- "delivers notifications to" --> n_Desktop_User_Interface
    n_Language_Server_Backend -- "queries bibliographic logic and models in" --> n_Core_Logic_and_Data_Model
    n_Language_Server_Backend -- "forwards navigation requests to" --> n_Desktop_User_Interface
    n_Build_and_Test_Utilities -- "tests and prepares data assets for" --> n_Core_Logic_and_Data_Model
    classDef added fill:#1f883d,stroke:#0b5d23,color:#ffffff;
    classDef modified fill:#bf8700,stroke:#7d4e00,color:#ffffff;
    classDef deleted fill:#cf222e,stroke:#82071e,color:#ffffff,stroke-dasharray:5 3;
    class n_Core_Logic_and_Data_Model,n_Desktop_User_Interface,n_HTTP_and_Citation_Service modified;
    linkStyle 6 stroke:#7d4e00,stroke-width:2px;
Loading

download artifacts · run 42491177887

@Svilen-Stefanov
Svilen-Stefanov changed the base branch from cb-review/760-base to main November 8, 2026 14:42
@Svilen-Stefanov
Svilen-Stefanov changed the base branch from main to cb-review/760-base November 8, 2026 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants