Skip to content

Send email alongside code for auth (replay of ruuvi/com.ruuvi.station#1745) - #1

Open
Svilen-Stefanov wants to merge 2 commits into
cb-review/1745-basefrom
cb-review/1745
Open

Svilen-Stefanov wants to merge 2 commits into
cb-review/1745-basefrom
cb-review/1745

Conversation

@Svilen-Stefanov

Copy link
Copy Markdown

Replay of ruuvi#1745 inside CodeBoarding's fork, to review it with CodeBoarding.

  • Head: the PR's head commit e005744, unchanged.
  • Base: the PR's merge base 1cbce0e, plus one commit that keeps only the CodeBoarding review workflow (ruuvi's own CI needs Firebase and Play secrets, so it is removed on this base branch).
  • The review runs CodeBoarding/CodeBoarding-action@v1 on the free hosted tier.

🤖 Generated with Claude Code

@github-actions

github-actions Bot commented Nov 19, 2026 •

Copy link
Copy Markdown

CodeBoarding review

Status: 8 changed components

See the full change in CodeBoarding.

Compared against the merge base: this branch is 1 commit behind cb-review/1745-base.

graph LR
    n_Cloud_Network_and_Calibration_Services["Cloud Network and Calibration Services"]
    n_Application_Foundation_and_Shared_UI["Application Foundation and Shared UI"]
    n_Application_Settings_and_Data_Forwarding["Application Settings and Data Forwarding"]
    n_Sensor_Details_and_Chart_Visualization["Sensor Details and Chart Visualization"]
    n_Common_Utilities_and_UI_Helpers["Common Utilities and UI Helpers"]
    n_Home_Screen_Widget_Integration["Home Screen Widget Integration"]
    n_Sensor_Configuration_and_Image_Customization["Sensor Configuration and Image Customization"]
    n_Local_Database_and_Persistence["Local Database and Persistence"]
    n_Firmware_Update_and_DFU_Management["Firmware Update and DFU Management"]
    n_Measurement_Unit_Conversion_and_AQI["Measurement Unit Conversion and AQI"]
    n_Dashboard_and_Sensor_Discovery["Dashboard and Sensor Discovery"]
    n_Bluetooth_Scanning_and_Device_Communication["Bluetooth Scanning and Device Communication"]
    n_Tag_Domain_Models_and_App_Guides["Tag Domain Models and App Guides"]
    n_Sensor_Alert_and_Alarm_Management["Sensor Alert and Alarm Management"]
    n_System_Boot_Receiver["System Boot Receiver"]
    n_Cloud_Network_and_Calibration_Services -- "triggers push alert notifications" --> n_Sensor_Alert_and_Alarm_Management
    n_Cloud_Network_and_Calibration_Services -- "accesses preferences and shared UI" --> n_Application_Foundation_and_Shared_UI
    n_Cloud_Network_and_Calibration_Services -- "uses utility extensions" --> n_Common_Utilities_and_UI_Helpers
    n_Cloud_Network_and_Calibration_Services -- "downloads and updates sensor images" --> n_Sensor_Configuration_and_Image_Customization
    n_Cloud_Network_and_Calibration_Services -- "persists sensor calibration offsets" --> n_Local_Database_and_Persistence
    n_Cloud_Network_and_Calibration_Services -- "checks runtime feature flags" --> n_Application_Settings_and_Data_Forwarding
    n_Cloud_Network_and_Calibration_Services -- "queries sensor firmware version" --> n_Bluetooth_Scanning_and_Device_Communication
    n_Cloud_Network_and_Calibration_Services -- "converts calibration units" --> n_Measurement_Unit_Conversion_and_AQI
    n_Cloud_Network_and_Calibration_Services -- "launches dashboard activity" --> n_Dashboard_and_Sensor_Discovery
    n_Cloud_Network_and_Calibration_Services -- "retrieves active widget identifiers" --> n_Home_Screen_Widget_Integration
    n_Measurement_Unit_Conversion_and_AQI -- "reads unit preference settings" --> n_Application_Foundation_and_Shared_UI
    n_Measurement_Unit_Conversion_and_AQI -- "formats and rounds values" --> n_Common_Utilities_and_UI_Helpers
    n_Dashboard_and_Sensor_Discovery -- "triggers network sync and sharing" --> n_Cloud_Network_and_Calibration_Services
    n_Dashboard_and_Sensor_Discovery -- "formats measurements and AQI" --> n_Measurement_Unit_Conversion_and_AQI
    n_Dashboard_and_Sensor_Discovery -- "retrieves and manages tags" --> n_Tag_Domain_Models_and_App_Guides
    n_Dashboard_and_Sensor_Discovery -- "displays sensor alarm triggers" --> n_Sensor_Alert_and_Alarm_Management
    n_Dashboard_and_Sensor_Discovery -- "uses permissions and UI elements" --> n_Application_Foundation_and_Shared_UI
    n_Dashboard_and_Sensor_Discovery -- "opens sensor card details" --> n_Sensor_Details_and_Chart_Visualization
    n_Dashboard_and_Sensor_Discovery -- "extends base activity and utilities" --> n_Common_Utilities_and_UI_Helpers
    n_Dashboard_and_Sensor_Discovery -- "launches background customization" --> n_Sensor_Configuration_and_Image_Customization
    n_Dashboard_and_Sensor_Discovery -- "evaluates feature flag behavior" --> n_Application_Settings_and_Data_Forwarding
    n_Bluetooth_Scanning_and_Device_Communication -- "notifies startup and logs telemetry" --> n_Cloud_Network_and_Calibration_Services
    n_Bluetooth_Scanning_and_Device_Communication -- "inspects scan and sync preferences" --> n_Application_Foundation_and_Shared_UI
    n_Bluetooth_Scanning_and_Device_Communication -- "forwards sensor readings to endpoints" --> n_Application_Settings_and_Data_Forwarding
    n_Bluetooth_Scanning_and_Device_Communication -- "formats data using utilities" --> n_Common_Utilities_and_UI_Helpers
    n_Bluetooth_Scanning_and_Device_Communication -- "stores sensor readings in database" --> n_Local_Database_and_Persistence
    n_Bluetooth_Scanning_and_Device_Communication -- "evaluates sensor readings against alarms" --> n_Sensor_Alert_and_Alarm_Management
    n_Bluetooth_Scanning_and_Device_Communication -- "schedules widget update refreshes" --> n_Home_Screen_Widget_Integration
    n_Tag_Domain_Models_and_App_Guides -- "converts tag measurement units" --> n_Measurement_Unit_Conversion_and_AQI
    n_Tag_Domain_Models_and_App_Guides -- "applies dashboard sensor sorting" --> n_Dashboard_and_Sensor_Discovery
    n_Tag_Domain_Models_and_App_Guides -- "checks alarm status for tags" --> n_Sensor_Alert_and_Alarm_Management
    n_Tag_Domain_Models_and_App_Guides -- "manages preferences and app settings" --> n_Application_Foundation_and_Shared_UI
    n_Tag_Domain_Models_and_App_Guides -- "uses dependency injection and UI extensions" --> n_Common_Utilities_and_UI_Helpers
    n_Tag_Domain_Models_and_App_Guides -- "assigns default background images" --> n_Sensor_Configuration_and_Image_Customization
    n_Tag_Domain_Models_and_App_Guides -- "queries sensor and history database" --> n_Local_Database_and_Persistence
    n_Sensor_Alert_and_Alarm_Management -- "syncs alert configurations to network" --> n_Cloud_Network_and_Calibration_Services
    n_Sensor_Alert_and_Alarm_Management -- "formats alarm thresholds with units" --> n_Measurement_Unit_Conversion_and_AQI
    n_Sensor_Alert_and_Alarm_Management -- "inspects tag properties and conversions" --> n_Tag_Domain_Models_and_App_Guides
    n_Sensor_Alert_and_Alarm_Management -- "reads alert preferences" --> n_Application_Foundation_and_Shared_UI
    n_Sensor_Alert_and_Alarm_Management -- "creates pending intents for sensor cards" --> n_Sensor_Details_and_Chart_Visualization
    n_Sensor_Alert_and_Alarm_Management -- "computes threshold diffs with utilities" --> n_Common_Utilities_and_UI_Helpers
    n_Sensor_Alert_and_Alarm_Management -- "reads and writes alarm persistence" --> n_Local_Database_and_Persistence
    n_Sensor_Alert_and_Alarm_Management -- "uses sensor settings elements" --> n_Sensor_Configuration_and_Image_Customization
    n_System_Boot_Receiver -- "reloads scan preferences on boot" --> n_Application_Foundation_and_Shared_UI
    n_Application_Foundation_and_Shared_UI -- "monitors foreground lifecycle" --> n_Common_Utilities_and_UI_Helpers
    n_Application_Foundation_and_Shared_UI -- "invokes firmware update UI status" --> n_Firmware_Update_and_DFU_Management
    n_Application_Foundation_and_Shared_UI -- "renders alarm trigger badge status" --> n_Sensor_Alert_and_Alarm_Management
    n_Application_Foundation_and_Shared_UI -- "initiates network sync and settings update" --> n_Cloud_Network_and_Calibration_Services
    n_Application_Foundation_and_Shared_UI -- "configures dashboard view types" --> n_Dashboard_and_Sensor_Discovery
    n_Application_Foundation_and_Shared_UI -- "navigates to about and orders measurements" --> n_Tag_Domain_Models_and_App_Guides
    n_Application_Foundation_and_Shared_UI -- "navigates to settings and refreshes flags" --> n_Application_Settings_and_Data_Forwarding
    n_Application_Foundation_and_Shared_UI -- "migrates sensor and alarm records" --> n_Local_Database_and_Persistence
    n_Application_Foundation_and_Shared_UI -- "reads unit codes and accuracy models" --> n_Measurement_Unit_Conversion_and_AQI
    n_Application_Foundation_and_Shared_UI -- "triggers widget previews and rerendering" --> n_Home_Screen_Widget_Integration
    n_Application_Foundation_and_Shared_UI -- "updates measurement display ordering" --> n_Sensor_Configuration_and_Image_Customization
    n_Application_Settings_and_Data_Forwarding -- "queries available measurement units" --> n_Measurement_Unit_Conversion_and_AQI
    n_Application_Settings_and_Data_Forwarding -- "configures alert notification channels" --> n_Sensor_Alert_and_Alarm_Management
    n_Application_Settings_and_Data_Forwarding -- "reads forwarding destination preferences" --> n_Application_Foundation_and_Shared_UI
    n_Application_Settings_and_Data_Forwarding -- "displays snackbars and injects view models" --> n_Common_Utilities_and_UI_Helpers
    n_Application_Settings_and_Data_Forwarding -- "updates cloud network settings" --> n_Cloud_Network_and_Calibration_Services
    n_Application_Settings_and_Data_Forwarding -- "accesses sensor settings and repository" --> n_Local_Database_and_Persistence
    n_Sensor_Details_and_Chart_Visualization -- "checks sensor cloud network status" --> n_Cloud_Network_and_Calibration_Services
    n_Sensor_Details_and_Chart_Visualization -- "formats export and chart units" --> n_Measurement_Unit_Conversion_and_AQI
    n_Sensor_Details_and_Chart_Visualization -- "controls bluetooth GATT sync" --> n_Bluetooth_Scanning_and_Device_Communication
    n_Sensor_Details_and_Chart_Visualization -- "renders sensor tag details" --> n_Tag_Domain_Models_and_App_Guides
    n_Sensor_Details_and_Chart_Visualization -- "evaluates alarm indicators on charts" --> n_Sensor_Alert_and_Alarm_Management
    n_Sensor_Details_and_Chart_Visualization -- "renders dialogs and buttons" --> n_Application_Foundation_and_Shared_UI
    n_Sensor_Details_and_Chart_Visualization -- "reads chart settings and feature flags" --> n_Application_Settings_and_Data_Forwarding
    n_Sensor_Details_and_Chart_Visualization -- "formats filenames and dates" --> n_Common_Utilities_and_UI_Helpers
    n_Sensor_Details_and_Chart_Visualization -- "navigates to sensor settings screens" --> n_Sensor_Configuration_and_Image_Customization
    n_Sensor_Details_and_Chart_Visualization -- "queries history and settings data" --> n_Local_Database_and_Persistence
    n_Common_Utilities_and_UI_Helpers -- "handles network operation statuses" --> n_Cloud_Network_and_Calibration_Services
    n_Common_Utilities_and_UI_Helpers -- "dispatches UI snackbar events" --> n_Application_Foundation_and_Shared_UI
    n_Common_Utilities_and_UI_Helpers -- "forwards NFC intent events" --> n_Sensor_Details_and_Chart_Visualization
    n_Home_Screen_Widget_Integration -- "resolves widget measurement unit types" --> n_Measurement_Unit_Conversion_and_AQI
    n_Home_Screen_Widget_Integration -- "reads widget preference configurations" --> n_Application_Foundation_and_Shared_UI
    n_Home_Screen_Widget_Integration -- "creates pending intents for sensor cards" --> n_Sensor_Details_and_Chart_Visualization
    n_Home_Screen_Widget_Integration -- "formats widget dates and times" --> n_Common_Utilities_and_UI_Helpers
    n_Home_Screen_Widget_Integration -- "retrieves favorite sensors for widgets" --> n_Local_Database_and_Persistence
    n_Home_Screen_Widget_Integration -- "fetches sensor snapshot from cloud" --> n_Cloud_Network_and_Calibration_Services
    n_Sensor_Configuration_and_Image_Customization -- "syncs sensor deletion and ordering to cloud" --> n_Cloud_Network_and_Calibration_Services
    n_Sensor_Configuration_and_Image_Customization -- "manages sensor alarm preferences" --> n_Sensor_Alert_and_Alarm_Management
    n_Sensor_Configuration_and_Image_Customization -- "uses preferences and UI scaffolding" --> n_Application_Foundation_and_Shared_UI
    n_Sensor_Configuration_and_Image_Customization -- "formats names and filenames" --> n_Common_Utilities_and_UI_Helpers
    n_Sensor_Configuration_and_Image_Customization -- "converts units for export" --> n_Measurement_Unit_Conversion_and_AQI
    n_Sensor_Configuration_and_Image_Customization -- "renders dashboard preview items" --> n_Dashboard_and_Sensor_Discovery
    n_Sensor_Configuration_and_Image_Customization -- "queries sensor info and controls LED" --> n_Bluetooth_Scanning_and_Device_Communication
    n_Sensor_Configuration_and_Image_Customization -- "inspects tag capabilities for export" --> n_Tag_Domain_Models_and_App_Guides
    n_Sensor_Configuration_and_Image_Customization -- "queries history and settings data" --> n_Local_Database_and_Persistence
    n_Sensor_Configuration_and_Image_Customization -- "displays firmware update section" --> n_Firmware_Update_and_DFU_Management
    n_Local_Database_and_Persistence -- "maps database records to domain tags" --> n_Tag_Domain_Models_and_App_Guides
    n_Local_Database_and_Persistence -- "converts and stores alarm thresholds" --> n_Sensor_Alert_and_Alarm_Management
    n_Local_Database_and_Persistence -- "sorts tags and resolves default names" --> n_Common_Utilities_and_UI_Helpers
    n_Firmware_Update_and_DFU_Management -- "initiates firmware upload via bluetooth" --> n_Bluetooth_Scanning_and_Device_Communication
    n_Firmware_Update_and_DFU_Management -- "checks sensor device type" --> n_Tag_Domain_Models_and_App_Guides
    n_Firmware_Update_and_DFU_Management -- "checks dev preferences and sends UI events" --> n_Application_Foundation_and_Shared_UI
    n_Firmware_Update_and_DFU_Management -- "compares firmware version strings" --> n_Common_Utilities_and_UI_Helpers
    n_Firmware_Update_and_DFU_Management -- "embeds in sensor settings UI" --> n_Sensor_Configuration_and_Image_Customization
    n_Firmware_Update_and_DFU_Management -- "persists sensor firmware versions" --> n_Local_Database_and_Persistence
    n_Firmware_Update_and_DFU_Management -- "configures network logging" --> n_Cloud_Network_and_Calibration_Services
    classDef added fill:#1f883d,stroke:#0b5d23,color:#ffffff;
    classDef modified fill:#bf8700,stroke:#7d4e00,color:#ffffff;
    classDef deleted fill:#cf222e,stroke:#82071e,color:#ffffff,stroke-dasharray:5 3;
    class n_Cloud_Network_and_Calibration_Services,n_Firmware_Update_and_DFU_Management modified;
    linkStyle 99 stroke:#0b5d23,stroke-width:2px;
Loading

download artifacts · run 44516754484

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants