Skip to content

6 or 7 bugs found and fixed #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mdanimal wants to merge 1 commit into
base: main
Choose a base branch
from
Open

6 or 7 bugs found and fixed #235

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 39 additions & 11 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ const correctMessage = document.getElementById('correct');

let targetNumber;
let attempts = 0;
const maxNumberOfAttempts = 5;
let maxNumberOfAttempts = 5;

// Returns a random number from min (inclusive) to max (exclusive)
// Usage:
Expand All @@ -22,12 +22,19 @@ function getRandomNumber(min, max) {
return Math.floor(Math.random() * (max - min)) + min;
}

function hideAllMessages() {
for (let elementIndex = 0; elementIndex < messages.length; elementIndex++) {
messages[elementIndex].style.display = 'none';
}
}

hideAllMessages();

function checkGuess() {
// Get value from guess input element
const guess = parseInt(guessInput.value, 10);
attempts = attempts + 1;

hideAllMessages();

if (guess === targetNumber) {
numberOfGuessesMessage.style.display = '';
Expand All @@ -42,8 +49,24 @@ function checkGuess() {
if (guess !== targetNumber) {
if (guess < targetNumber) {
tooLowMessage.style.display = '';
tooHighMessage.style.display = 'none';

}
else if (guess === targetNumber) {
correctMessage.style.display = ''
tooHighMessage.style.display = 'none';
tooLowMessage.style.display = 'none';


} else {
tooLowMessage.style.display = '';
tooHighMessage.style.display = '';
tooLowMessage.style.display = 'none';
}

if (guess > 100 || guess < 1) {
alert('Please enter a number between 1 and 100');
return;

}

const remainingAttempts = maxNumberOfAttempts - attempts;
Expand All @@ -52,38 +75,43 @@ function checkGuess() {
numberOfGuessesMessage.innerHTML = `You guessed ${guess}. <br> ${remainingAttempts} guesses remaining`;
}

if (attempts ==== maxNumberOfAttempts) {
if (attempts === maxNumberOfAttempts) {
submitButton.disabled = true;
guessInput.disabled = true;
guessInput.disabled = true
}

guessInput.value = '';


resetButton.style.display = '';
}

function hideAllMessages() {
for (let elementIndex = 0; elementIndex <= messages.length; elementIndex++) {
/*function hideAllMessages() {
for (let elementIndex = 0; elementIndex < messages.length; elementIndex++) {
messages[elementIndex].style.display = 'none';
}
}
}*/

// hideAllMessages();

funtion setup() {
function setup() {
// Get random number
targetNumber = getRandomNumber(1, 100);
console.log(`target number: ${targetNumber}`);

// Reset number of attempts
maxNumberOfAttempts = 0;
maxNumberOfAttempts = 5;

// Enable the input and submit button
submitButton.disabeld = false;
submitButton.disabled = false;
guessInput.disabled = false;

hideAllMessages();
resetButton.style.display = 'none';
}



submitButton.addEventListener('click', checkGuess);
resetButton.addEventListener('click', setup);

Expand Down