SSF-188 Automated Order Lifecycle Emails by Juwang110 · Pull Request #162 · Code-4-Community/ssf

Juwang110 · 2026-04-21T14:54:02Z

ℹ️ Issue

Closes https://vidushimisra.atlassian.net/jira/software/projects/SSF/boards/1?jql=assignee%20%3D%20712020%3A10ef9ad9-e290-4bbd-8c4b-cb215e8d449a&selectedIssue=SSF-188

📝 Description

Email templates for:

Pantry’s Food Request has a matched order
FM’s donation has been matched to an order
Food Request closed

✔️ Verification

BEFORE TESTING: Add 2 new environment variables:

AWS_SES_SENDER_EMAIL (set this to one of your emails, this will be the address that sends the emails for you to verify)
SEND_AUTOMATED_EMAILS (switch this to true to turn on Cognito account creation and email sending permissions)
Add your email that you put in the AWS_SES_SENDER_EMAIL into the following AWS SES Identities: https://us-east-2.console.aws.amazon.com/ses/home?region=us-east-2#/identities

Tested each workflow to ensure the proper sender, subject, message, attachments were all there.

Same testing as #127

I verified it worked via new tests and testing email functionality with postman.

🏕️ (Optional) Future Work / Notes

For food request closed the functionality is as follows (per Yurika):

For manual close (closeRequest endpoint):

coordinator = volunteer who hit endpoing with req.user.id

For auto close (updateRequestStatus):

coordinator = the last volunteer who touched an associated order of that request that was most recently delivered.

sam-schu

For sending the emails:

For consistency with our other emails, can we send the emails outside of the transaction, so the order is still created even if an email fails to send? (We do plan to add better handling for failed emails across the board)
Can we try sending both emails, even if one fails?

sam-schu

Confirmed the emails are properly sent! A few comments on the contents:

Can we link the text "log into the platform" rather than including the link at the end of the email?
Can we turn the coordinator email into a link?
For the manufacturer email, can we make sure the different address lines appear on different lines in the email body, and add a comma between city and state?

814 Cedar Hollow Way
[Unit 1]
Madison, WI 53711
[US]

dburkhart07

sorry this is so many comments lol. should hopefully be good after this <3

dburkhart07 · 2026-05-08T04:43:03Z

+
+    it('sends pantry closed email with last delivered order assignee on auto-close', async () => {
+      const requestId = 1;
+      const pantry = await testDataSource.getRepository(Pantry).findOne({


nit: can we cast both of these rather than a !

dburkhart07 · 2026-05-08T04:44:39Z

+      await service.updateRequestStatus(1);
+
+      const request = await service.findOne(1);
+      expect(request.status).toBe(FoodRequestStatus.CLOSED);


Can we either add to this test or create another test that, in this event, in addition to the request still closing, that the error message is also logged?

dburkhart07 · 2026-05-08T04:45:05Z

+      mockEmailsService.sendEmails.mockRejectedValueOnce(
+        new Error('SMTP error'),
+      );
+


Can we make sure before this update call, that the request beforehand was marked as active?

dburkhart07 · 2026-05-08T04:45:19Z

+        `UPDATE food_requests SET status = 'closed' WHERE request_id = 1`,
+      );
+
+      await service.updateRequestStatus(1);


can we make sure the request was closed before this call?

dburkhart07 · 2026-05-08T05:19:53Z

+      expect(item1After?.reservedQuantity).toBe(item1Before?.reservedQuantity);
+      expect(item2After?.reservedQuantity).toBe(item2Before?.reservedQuantity);
    });
  });


Can we add the following tests:

Rollsback transaction when the donation service match fails

Add a new test for throwing an error when we have 0 donation items (an empty map gets passed in), since we cant create an order with no items/allocations

A test where the request is not found

dburkhart07 · 2026-05-08T05:21:32Z

-            ', ',
-          )}`,
+        const donationItemIds = Array.from(itemAllocations.keys());
+        const donationItems = await this.donationItemsService.getByIds(


Can we make sure that donationItems has at least one item in it beforehand, and throw a BadReqeustException otherwise?

dburkhart07 · 2026-05-08T05:23:26Z

-      const donationItems = await this.donationItemsService.getByIds(
-        donationItemIds,
-      );
+        const fmDonations = await this.donationRepo.find({


Can we also make sure the food manufacturer has some donations?

dburkhart07 · 2026-05-08T05:27:38Z

-      for (const donationItem of donationItems) {
-        const id = donationItem.itemId;
-        const quantityToAllocate = itemAllocations.get(id)!;
+        const invalidItems = donationItems.filter(


I'm thinking about the edge case where we have a bunch of fulfilled donations. In the instance where we have donation items part of this filled donation, we will get an issue about the desired quantity being more than the fulfilled quantity. Can we get either @sam-schu or @Yurika-Kan's thoughts on this? should we keep it the way it is, or throw a potentially more helpful error that no donation item ids can belong to fulfilled donations, in addition to needing to be from donations from this food manufacturer.

dburkhart07 · 2026-05-08T05:28:28Z

+      await this.dataSource.transaction(async (transactionManager) => {
+        validateId(manufacturerId, 'Food Manufacturer');
+        validateId(requestId, 'Request');
+


Can we also validate early on that all the allocation values are greater than 0?

Juwang110 and others added 6 commits April 12, 2026 23:01

email templates

ddbe3fb

multiple items for email template

4058b03

logic for sending emails

61f6859

tests

83baa1c

Merge branch 'main' into jw/ssf-188-automated-order-lifecycle-emails

ff7d8e6

fix bug

5deb81b

Yurika-Kan requested review from sam-schu and swarkewalia April 24, 2026 18:12

sam-schu requested changes Apr 28, 2026

View reviewed changes

Comment thread apps/backend/src/emails/emailTemplates.ts Outdated

Juwang110 and others added 2 commits April 29, 2026 13:22

comments

6006842

Merge branch 'main' into jw/ssf-188-automated-order-lifecycle-emails

dd564f4

Juwang110 requested a review from sam-schu April 29, 2026 17:24

Juwang110 added 3 commits April 29, 2026 15:27

Merge branch 'main' into jw/ssf-188-automated-order-lifecycle-emails

721c0c4

Merge branch 'main' into jw/ssf-188-automated-order-lifecycle-emails

25664af

Merge branch 'main' into jw/ssf-188-automated-order-lifecycle-emails

ef55069

sam-schu requested changes May 2, 2026

View reviewed changes

Juwang110 and others added 2 commits May 4, 2026 14:03

Merge branch 'main' into jw/ssf-188-automated-order-lifecycle-emails

6ef0e51

comments

2470ddb

Juwang110 requested a review from sam-schu May 4, 2026 19:44

finish test

aa7871a

dburkhart07 requested changes May 5, 2026

View reviewed changes

dburkhart07 removed the request for review from swarkewalia May 5, 2026 05:33

Juwang110 and others added 3 commits May 5, 2026 11:15

tests and comments

0c8f55a

shipment address instead of mailing

8446636

Merge branch 'main' into jw/ssf-188-automated-order-lifecycle-emails

0701342

Juwang110 mentioned this pull request May 6, 2026

[SSF-180, 189, 193] - Automated Emails Implementation #154

Open

food request closed email

1b7750f

Juwang110 requested a review from dburkhart07 May 6, 2026 21:02

sam-schu requested changes May 7, 2026

View reviewed changes

Juwang110 requested a review from sam-schu May 7, 2026 20:32

Juwang110 and others added 2 commits May 7, 2026 16:38

comments

f658e67

Merge branch 'main' into jw/ssf-188-automated-order-lifecycle-emails

0a285e3

dburkhart07 requested changes May 8, 2026

View reviewed changes

Conversation

Juwang110 commented Apr 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

ℹ️ Issue

📝 Description

✔️ Verification

🏕️ (Optional) Future Work / Notes

Uh oh!

sam-schu left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sam-schu left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dburkhart07 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Juwang110 commented Apr 21, 2026 •

edited

Loading