feat: reinject dylib into node/golang processes#389
Conversation
Merging this PR will not alter performance
|
Greptile SummaryThis PR adds macOS SIP (System Integrity Protection) re-injection of
Confidence Score: 5/5Safe to merge — the change is a targeted macOS SIP workaround with no effect on Linux paths. Both shell scripts correctly gate the re-injection behind a non-empty check on SAMPLY_DYLD_INSERT_LIBRARIES, which is only populated by samply on macOS, so Linux execution is completely unaffected. The set -u promotion in node.sh is paired with required :- guards on every previously-bare variable reference. The samply rev bump in Cargo.toml is pinned to a commit hash, consistent with the repo's dependency policy. No files require special attention. Important Files Changed
|
3c42917 to
252f8ef
Compare
macOS SIP strips DYLD_* across system-binary execs, dropping samply's preload from the subtree. samply now exposes the value under a SAMPLY_-prefixed name that SIP doesn't strip; restore it in the node.sh introspection shim so the profiler's preload re-arms in the real node.
macOS SIP strips DYLD_* across system-binary execs, dropping samply's preload from the subtree. samply now exposes the value under a SAMPLY_-prefixed name that SIP doesn't strip; restore it in the go.sh introspection shim so the profiler's preload re-arms in the real go.
252f8ef to
aca0831
Compare
No description provided.