Skip to content

chore: bump samply-codspeed to fix MacOS sigkills#386

Open
not-matthias wants to merge 1 commit into
mainfrom
cod-2762-samply-sigkills-dsymutil
Open

chore: bump samply-codspeed to fix MacOS sigkills#386
not-matthias wants to merge 1 commit into
mainfrom
cod-2762-samply-sigkills-dsymutil

Conversation

@not-matthias
Copy link
Copy Markdown
Member

No description provided.

@greptile-apps
Copy link
Copy Markdown

greptile-apps Bot commented Jun 1, 2026

Greptile Summary

This PR bumps the samply-codspeed fork dependency from commit e8b8dacc to c11964c5 to fix MacOS SIGKILL issues during profiling. The change is localized to the dependency declaration and the auto-regenerated lock file.

  • Cargo.toml: updates the samply git dep to the new rev, correctly pinned to a specific commit hash (not a branch).
  • Cargo.lock: all 8 downstream crates sourced from samply-codspeed are consistently updated to the new rev.

Confidence Score: 5/5

Safe to merge — the change is a targeted rev bump of the CodSpeedHQ samply fork pinned to a specific commit, with the lock file updated consistently across all affected crates.

Only two files change: Cargo.toml advances the samply rev, and Cargo.lock reflects the downstream update for all 8 crates sourced from the fork. The dependency is correctly pinned to a specific rev, the lock file is fully consistent, and no application logic is touched.

No files require special attention.

Important Files Changed

Filename Overview
Cargo.toml Bumps the samply git dependency rev from e8b8dacc to c11964c5 to fix MacOS sigkill issues; correctly pinned to a specific rev per project standards.
Cargo.lock Lock file updated consistently for all 8 samply-codspeed-sourced crates to the new rev.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A["Cargo.toml\nsamply git dep"] -->|"rev: e8b8dacc (old)"| B["samply-codspeed fork\n(CodSpeedHQ/samply-codspeed)"]
    A -->|"rev: c11964c5 (new)"| C["samply-codspeed fork\n(MacOS sigkill fix)"]
    C --> D["fxprof-processed-profile"]
    C --> E["samply"]
    C --> F["samply-api"]
    C --> G["samply-debugid"]
    C --> H["samply-object"]
    C --> I["samply-quota-manager"]
    C --> J["samply-symbols"]
    C --> K["wholesym"]
Loading

Reviews (1): Last reviewed commit: "chore: bump samply to fix sigkill" | Re-trigger Greptile

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Jun 1, 2026

Merging this PR will not alter performance

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

✅ 7 untouched benchmarks


Comparing cod-2762-samply-sigkills-dsymutil (375afd1) with main (f79d57d)

Open in CodSpeed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant