Skip to content

fix: support perf jitdumps on macos #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
not-matthias wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: support perf jitdumps on macos #385

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1436f02
chore: bump framehop
not-matthias Jun 1, 2026
d887b43
Revert "fix(walltime): disable PYTHON_PERF_JIT_SUPPORT on macOS"
not-matthias Jun 1, 2026
938d05e
chore: use samply with latest linux-perf-data
not-matthias Jun 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 15 additions & 16 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,9 @@ async-trait = "0.1.89"
libc = { workspace = true }
bincode = "1.3.3" # Pinned to 1.x: 2.0 changes the wire format and serde integration
object = "0.39"
linux-perf-data = { git = "https://github.com/mstange/linux-perf-data.git", rev = "da5bce4b9fb724e84b1eea0cb6ab9c8a291bc676", features = [
linux-perf-data = { git = "https://github.com/AvalancheHQ/linux-perf-data.git", rev = "effe486", features = [
"zstd",
] } # unreleased main as of 2026-03-19
] } # unreleased branch as of 2026-06-01
Comment on lines +49 to +51
Copy link
Copy Markdown

@greptile-apps greptile-apps Bot Jun 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Both new git rev values are short abbreviated SHAs (7–8 chars) rather than the full 40-char SHA that was used previously (e.g. the old linux-perf-data rev was da5bce4b9fb724e84b1eea0cb6ab9c8a291bc676 and the old samply rev was e8b8dacc042978953a6db9616c72846f7b8d5062). The lock file resolves them correctly, but abbreviated revs leave a theoretical ambiguity window as the repository grows. Using the full SHA matches the pattern established in the rest of the codebase and the pinning rule intent.

Suggested change
linux-perf-data = { git = "https://github.com/AvalancheHQ/linux-perf-data.git", rev = "effe486", features = [
"zstd",
] } # unreleased main as of 2026-03-19
] } # unreleased branch as of 2026-06-01
linux-perf-data = { git = "https://github.com/AvalancheHQ/linux-perf-data.git", rev = "effe486d4a951d6655007a163b837e7c4a15848c", features = [
"zstd",
] } # unreleased branch as of 2026-06-01

Rule Used: Pin Cargo git dependencies to tag or rev, neve... (source)

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

debugid = "0.8.0"
memmap2 = "0.9.10"
nix = { version = "0.31.3", features = ["fs", "time", "user"] }
Expand All @@ -69,7 +69,7 @@ rmp-serde = "1.3.1"
uuid = { version = "1.23.1", features = ["v4"] }
which = "8.0.2"
crc32fast = "1.5.0"
samply = { git = "https://github.com/CodSpeedHQ/samply-codspeed", rev = "e8b8dacc042978953a6db9616c72846f7b8d5062" }
samply = { git = "https://github.com/CodSpeedHQ/samply-codspeed", rev = "75ae209d" }
Copy link
Copy Markdown

@greptile-apps greptile-apps Bot Jun 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Same short-rev concern as linux-perf-data above — the full SHA resolved in the lock file is 75ae209d1f22272e046be816f785509ba3e0a163.

Suggested change
samply = { git = "https://github.com/CodSpeedHQ/samply-codspeed", rev = "75ae209d" }
samply = { git = "https://github.com/CodSpeedHQ/samply-codspeed", rev = "75ae209d1f22272e046be816f785509ba3e0a163" }

Rule Used: Pin Cargo git dependencies to tag or rev, neve... (source)

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!


[target.'cfg(target_os = "linux")'.dependencies]
procfs = "0.18"
Expand Down
4 changes: 1 addition & 3 deletions src/executor/helpers/env.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,7 @@ pub fn get_base_injected_env(
("PYTHONHASHSEED".into(), "0".into()),
(
"PYTHON_PERF_JIT_SUPPORT".into(),
// FIXME(COD-2645): Keep this disabled on macOS. Enabling it causes
// many unresolved addresses on the stack when profiling with samply.
if mode == RunnerMode::Walltime && !cfg!(target_os = "macos") {
if mode == RunnerMode::Walltime {
"1".into()
} else {
"0".into()
Expand Down