TP-3895: add redis support for deleted resources

[tr-emp-090]

🛡️ Security Checklist

Review and check all that apply before requesting a review.

• Secrets: I have verified that no API keys, passwords, or certificates are hardcoded.
• Dependencies: I have checked for known vulnerabilities in any new libraries added.
• Data Handling: Sensitive data (PII) is encrypted or masked in logs.
• Input Validation: All user-provided input is sanitized to prevent SQLi or XSS.
• Permissions: New endpoints or features follow the Principle of Least Privilege.

⚙️ Backend & Performance

• Database: I have checked for N+1 query issues and verified index usage.
• Migrations: Database migrations are reversible (where applicable) and tested.
• Error Handling: Errors are caught and returned with appropriate HTTP status codes.
• Scalability: Large datasets are handled via pagination, not loaded entirely into memory.
• Async: Long-running tasks are moved to background workers (if applicable).

🧪 Testing & Quality

• Unit Tests: Added/updated tests for the core logic.
• Integration: Verified that API contracts haven't broken for downstream services.
• Observability: Added logs or metrics to track the success/failure of this feature.
• Documentation: Updated Swagger/OpenAPI specs or internal READMEs.

✍️ Sign-off

• I confirm that I have performed a self-review of this code from a security perspective.

Reviewer Sign-off: (To be completed by the reviewer)

• Security standards verified.

Summary by CodeRabbit

• New Features

  • Added support for deleting one or more fields from a Redis hash.
  • Supports individual fields or an array of fields and safely handles empty requests.

• Chores

  • Updated the package version to 1.6.14.

[coderabbitai]

📝 Walkthrough

Walkthrough

Adds Redis.hdel support for deleting one or more hash fields, including empty-input handling and array arguments. Updates the package version from 1.6.13 to 1.6.14.

Changes

Redis hash deletion

Layer / File(s)	Summary
Add Redis hash field deletion src/redis.js, package.json	Redis.hdel handles empty and array-based field arguments before delegating to _execute('hdel', ...); the package version is bumped to 1.6.14.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: tr-emp-042

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title matches the main change: adding Redis support for deleted resources via a new hash-delete method.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch TP-3895-add-redis-support-for-deleted-resources

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

🧹 Nitpick comments (1)

src/redis.js (1)

63-72: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value

Prefer native array properties and methods over lodash.

Since fields is collected using a rest parameter (...fields), it is guaranteed to be a native JavaScript array. Using fields.length and Array.isArray() is more idiomatic and performant than relying on lodash for these simple checks.

♻️ Proposed refactor

-    if (_.size(fields) == 0) {
+    if (fields.length === 0) {
       return 0;
     }
     // Support passing a single array of fields: hdel(key, [f1, f2])
-    if (_.size(fields) == 1 && _.isArray(fields[0])) {
+    if (fields.length === 1 && Array.isArray(fields[0])) {
       fields = fields[0];
     }
-    if (_.size(fields) == 0) {
+    if (fields.length === 0) {
       return 0;
     }

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/redis.js` around lines 63 - 72, Update the fields validation in the hdel
flow to use the native fields.length property for empty checks and
Array.isArray(fields[0]) for detecting a single array argument, replacing the
corresponding lodash calls while preserving the existing early returns and
flattening behavior.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@package.json`:
- Line 3: Synchronize the package-lock.json metadata with the 1.6.14 version
declared in package.json by running npm install or npm version. Ensure both the
lockfile root package version and any corresponding package metadata reflect
1.6.14 without changing dependency versions unnecessarily.

---

Nitpick comments:
In `@src/redis.js`:
- Around line 63-72: Update the fields validation in the hdel flow to use the
native fields.length property for empty checks and Array.isArray(fields[0]) for
detecting a single array argument, replacing the corresponding lodash calls
while preserving the existing early returns and flattening behavior.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: bccf8fa8-5f6b-487c-99d0-e9764ee6ae9f

📥 Commits

Reviewing files that changed from the base of the PR and between 553966d and 2cf4160.

📒 Files selected for processing (2)

• package.json
• src/redis.js

[coderabbitai]

📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win

Synchronize package-lock.json with the new version.

The package.json version has been bumped to 1.6.14, but codebase context indicates that package-lock.json is out of sync (still reflecting 1.6.5).

Please run npm install (or use npm version) to update the lockfile and prevent version metadata drift during downstream installations.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@package.json` at line 3, Synchronize the package-lock.json metadata with the
1.6.14 version declared in package.json by running npm install or npm version.
Ensure both the lockfile root package version and any corresponding package
metadata reflect 1.6.14 without changing dependency versions unnecessarily.