Remove overlap mesh requirement for bilin and delaunay methods#122
Remove overlap mesh requirement for bilin and delaunay methods#122paullric wants to merge 1 commit into
Conversation
vijaysm
left a comment
vijaysm
left a comment
There was a problem hiding this comment.
I haven't tested the PR locally to see whether bilin/delaunay works fine without specifying overlap meshes. Made some comments during review. Please address them. I'll update the approval after local tests.
|
|
||
| // Check overlap mesh | ||
| if (meshOverlap.nodes.size() == 0) { | ||
| if ((strMapAlgorithm != "delaunay") && |
There was a problem hiding this comment.
Why a double if check here? Consolidate the check into a single one
| "and input mesh area.\n Disabling checks for consistency."); | ||
| fCheckConsistency = false; | ||
| if (meshOverlap.nodes.size() != 0) { | ||
| if (fabs(dTotalAreaOverlap - dTotalAreaInput) > 1.0e-10) { |
There was a problem hiding this comment.
You can combine the checks here again
| Mesh(const std::string & strFile) { | ||
| Read(strFile); | ||
| if (strFile != "") { | ||
| Read(strFile); |
There was a problem hiding this comment.
This is misleading. If someone passed an empty string, then you should error out or print a warning message.
| } | ||
|
|
||
| // Overlap mesh | ||
| if (strOverlapMesh == "") { |
There was a problem hiding this comment.
You should still be doing this check for FV projections. Perhaps need to check whether this is bilin/delaunay context first?
|
Did you get a chance to address my comments? |
2 participants
The overlap mesh isn't used for bilinear or delaunay maps. This PR removes the requirement that ov_mesh be specified on the GenerateOverlapMesh command line for these cases.