use native format for http - #328
Draft
serprex wants to merge 10 commits into
Draft
Conversation
partially as http optimization, partially as way to make drivers consistent, partially as way to increase code reuse maybe not worth coupling these code paths when we should just get rid of http
1. use curl_url 2. add cancel support to streams, replaces progress callback 3. chfdw_version_ge for version checks 4. don't be persistent about ch_http_server_version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
share code between binary & http by using native format over http
partially as http optimization, partially as way to make drivers consistent, partially as way to increase code reuse
http is just transport. would be even simpler if we cut
clickhouse_raw_queryin #329