Update import_schema_1.out for ClickHouse's new Float32 rendering - #327
Merged
Conversation
0c85edc updated the primary expected output for CH 26.7+'s changed Float32 min/max rendering, but missed the PG13-17 alternate (import_schema_1.out), which still carried the pre-26.7 values. Since postgres.yml installs "latest" ClickHouse unpinned across the whole PG version matrix, every job now hits the new rendering, leaving PG13-17 comparing against a stale expected file.
theory
approved these changes
Jul 29, 2026
theory
left a comment
theory
left a comment
Collaborator
There was a problem hiding this comment.
Just update test/expected/import_schema_1.out please. Leave the rest as-is.
JoshDreamland
force-pushed
the
fix-import-schema-float-expected
branch
from
July 29, 2026 22:32
cd38afa to
667c203
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
0c85edcupdated the primaryimport_schema.outfor ClickHouse 26.7+'s changed Float32 min/max rendering (1.1754942e-38→1.1754944e-38,3.4028233e38→3.4028235e38), but didn't touch the PG13-17 alternate,import_schema_1.out, which still carries the pre-26.7 values.postgres.ymlinstalls "latest" ClickHouse unpinned across the entire PG version matrix (13-19), so every job now gets the new rendering — PG13-17 jobs fail comparing against the stale alternate, while PG18-19 (which use the already-updated primary) pass.main's current HEAD directly (no code changes): same PG13-17 failure, proving it's a live, unrelated regression rather than anything specific to Ship constant NULL-carrying IN lists via native IN in truth context #321.import_schema_1.outto match what's already in the primary file; the remaining (legitimate) diff between the two — PG13-17 lacking\d's "Not-null constraints:" section — is untouched.Test plan
make installcheck REGRESS=import_schemapasses locally (PG18, exercises the primary file)