Skip to content

Add vitest-pool-bun: a Vitest 4.1 custom pool that runs tests in Bun (PoC)#800

Draft
Copilot wants to merge 6 commits into
mainfrom
copilot/vitest-pool-bun
Draft

Add vitest-pool-bun: a Vitest 4.1 custom pool that runs tests in Bun (PoC)#800
Copilot wants to merge 6 commits into
mainfrom
copilot/vitest-pool-bun

Conversation

Copilot AI commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

Summary

The vitest-pool-bun proof-of-concept package had no CI coverage. This adds a dedicated workflow that exercises its example suite on every change.

Changes

  • New workflow .github/workflows/vitest-pool-bun.yml:
    • paths-scoped to vitest-pool-bun/** (and the workflow file) so it only runs when the PoC changes; triggers on push to main, pull_request, and workflow_dispatch.
    • Single tests job: Node 24 host + Bun 1.3.14 worker (pinned oven-sh/setup-bun), npm install, then npm run demo (builds and runs the green example suite under Bun).
    • Follows existing repo conventions: permissions: {}, SHA-pinned actions, concurrency group with cancel-in-progress.

Only the green demo script is wired in; demo:failure and demo:diagnostics are intentionally excluded since they assert a failing/crashing run and would fail the job. No OTEL/coverage env block, as this standalone package is outside the workspaces and doesn't use the repo's coverage tooling.

Checklist

  • A human-readable description of the changes was provided to include in CHANGELOG

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@codecov

codecov Bot commented Jun 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Comment thread .github/workflows/vitest-pool-bun.yml Fixed
Copilot AI changed the title Add vitest-pool-bun: a Vitest 4.1 custom pool that runs tests in Bun (PoC) ci: add CI workflow for the vitest-pool-bun PoC Jun 3, 2026
Copilot AI requested a review from peter-leonov-ch June 3, 2026 12:22
@peter-leonov-ch peter-leonov-ch changed the title ci: add CI workflow for the vitest-pool-bun PoC Add vitest-pool-bun: a Vitest 4.1 custom pool that runs tests in Bun (PoC) Jun 3, 2026
@peter-leonov-ch

Copy link
Copy Markdown
Collaborator

@copilot the CI seems to be working fine, great job! now, create a PR to this branch with running some of node unit tests using this runner pool

Copilot AI commented Jun 3, 2026

Copy link
Copy Markdown
Contributor Author

@peter-leonov-ch I've opened a new pull request, #801, to work on those changes. Once the pull request is ready, I'll request review from you.

…n Bun pool (PoC) (#801)

## Summary

The `vitest-pool-bun` proof-of-concept package had no CI coverage. This
PR adds a dedicated workflow that now validates both the PoC example
suite and a selected subset of repository Node unit tests using the Bun
pool runner.

- New workflow `.github/workflows/vitest-pool-bun.yml`, path-scoped to
`vitest-pool-bun/**` (and the workflow file), triggered on `push` to
`main`, `pull_request`, and `workflow_dispatch`.
- Keeps a pinned, least-privilege setup (`permissions: {}`, SHA-pinned
actions, concurrency cancel-in-progress).
- Runs `npm run demo` in `vitest-pool-bun` (green PoC suite), then
installs root dependencies and runs selected Node unit tests through Bun
pool using:
  - `vitest-pool-bun/examples/clickhouse-node-unit.config.mjs`
  - `packages/client-node/__tests__/unit/node_user_agent.test.ts`
  - `packages/client-node/__tests__/unit/node_default_logger.test.ts`

## Checklist

- [ ] Unit and integration tests covering the common scenarios were
added
- [ ] A human-readable description of the changes was provided to
include in CHANGELOG
- [ ] For significant changes, documentation in
https://github.com/ClickHouse/clickhouse-docs was updated with further
explanations or tutorials

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>

- name: Install dependencies
run: |
npm install
- name: Install dependencies (clickhouse-js root)
working-directory: .
run: |
npm install
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants