You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Summary
Tiny test-only fix (2 lines changed) correcting wrong DateTime64 test values in the v1 test suite. In ClientIntegrationTest.getSimpleTypes() the expected minimum for DateTime64(3) is changed from a pre-epoch value (1969-12-31 23:59:59.999) to 1970-01-01 00:00:00, and in ClickHousePreparedStatementTest.testInsertQueryDateTime64() a parameter is now bound as a LocalDateTime object via setObject instead of a raw epoch-micros long via setLong. No production source code is touched.
What this impacts
Test code only: clickhouse-client integration test data provider and clickhouse-jdbc prepared-statement test.
No user-facing surfaces or shipped artifacts affected.
Concerns
The ClientIntegrationTest change replaces a pre-epoch (negative) DateTime64 boundary value with the epoch itself, slightly reducing coverage of sub-epoch DateTime64 handling — worth confirming this reflects intended server/driver behavior rather than papering over a regression.
No linked issue, though the change is trivial enough that this is acceptable.
Required reviewer action
low — AI review with no comments → eligible for auto-merge per repo policy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes datetime64 wrong value in tests of V1
Checklist
Delete items not relevant to your PR: