You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Summary
Adds a brand-new migration-helpers Maven module with ConfigurationMigrationHelper and ConfigPropertyCache that convert v1 (0.7.1) configuration properties, maps, and JDBC connection URLs to the v2 (0.9.8+) format — auto-prefixing server settings with clickhouse_setting_, headers with http_header_, applying renamed-key mappings from bundled .properties resource files, and enriching known-key sets via reflection over v1/v2 option enums when present on the classpath. Includes an example class, unit + testcontainers integration tests, and a migration doc. The PR also bundles a root pom.xml version bump (0.10.0-rc1-SNAPSHOT → 0.11.0-rc1-SNAPSHOT), a CHANGELOG entry, and a whitespace-only .github/workflows/build.yml edit.
What this impacts
New standalone migration-helpers module (main sources, resources, tests) — no existing client/driver source files are modified.
Root pom.xml (project revision bump) and CHANGELOG.
Large diff rule fires (High): +1802 lines across 16 files — per repo policy this should be split or reviewed in parts.
Potential secret leak in shipped example: JdbcConfigurationMigrationExample.executeQueryWithMigratedConfig logs the full converted Properties at INFO (log.info("v2Props: {}", v2Props)), which includes user/password keys — matches the security rubric's "logging that could leak secrets" pattern, even though it's example code in src/main.
New module is not added to the root pom <modules> list, so it won't be built, tested, or released by the reactor — likely an oversight that silently makes the CI test claims moot.
Bundling / intent drift: the root project version bump (0.10.0 → 0.11.0-rc1-SNAPSHOT) and the build.yml whitespace edit are unrelated to the migration-helper feature and have no linked issue; no Closes # reference at all.
Reflection usage (Class.forName, getMethod, field access) is confined to one-time static cache initialization in the new module — not client hot-path, so noted but not risk-promoting on its own.
Several required checks (Compile JDK 8, SonarCloud, Cursor Bugbot) were still in progress at triage time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Checklist
Delete items not relevant to your PR: