chore(byoc): add GCP priviledge documentation#6183
Open
bojand wants to merge 3 commits into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
4 Skipped Deployments
|
dhtclk
previously requested changes
May 8, 2026
Collaborator
dhtclk
left a comment
dhtclk
left a comment
There was a problem hiding this comment.
Some nits on sentence casing and standardization.
4 tasks
Co-authored-by: Dominic Tran <dominic.tran@clickhouse.com>
Blargian
approved these changes
May 9, 2026
Blargian
dismissed
dhtclk’s stale review
Minor edits, don't want to block unnecessarily
Blargian
pushed a commit
to Blargian/clickhouse-docs
that referenced
this pull request
May 11, 2026
scripts/vale/changed_lines_to_json.py only recorded the start line of each `@@` hunk header, so vale_annotations.py filtered Vale findings on every other added line out of the diff. Result: error-level Vale findings past the first added line of each hunk silently passed CI (e.g. heading-casing errors on lines 44 and 56 of PR ClickHouse#6183). Expand each hunk into the full added range using the count from the unified=0 hunk header. Pure deletions (`+A,0`) yield an empty range, as expected. Adds unit tests for the parser covering single-line, multi-line, deletion, modified, multi-hunk, and trailing-context cases. Five of the six tests fail against the previous behaviour. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
yiyang-shao
reviewed
May 11, 2026
Contributor
There was a problem hiding this comment.
Shall we mark the old sections with "AWS" explicitly?
bojand
commented
May 11, 2026
CloudFormation IAM roles -> AWS IAM roles
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds reference documentation for BYOC privilege for GCP.
Checklist