fix(CardHorizontal): 🐛 Security URL validation#1000
Open
punkbit wants to merge 7 commits into
Open
Conversation
- Validate infoUrl starts with http:// or https:// to prevent javascript: URI attacks - Add noopener,noreferrer to window.open for security
- Replace regex with native URL API for more robust validation - Export isValidHttpUrl utility function - Add unit tests for URL validation
🦋 Changeset detectedLatest commit: 0b97e30 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
punkbit
requested review from
EvandroLG,
ariser,
hoorayimhelping and
kunalpanchal
Contributor
📚 Storybook Preview Deployed✅ Preview URL: https://click-7z8wvwydc-clickhouse.vercel.app Built from commit: |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
Improved how the
CardHorizontalcomponent handles external links to keep end-users safe.How?
Tickets?
N/A
Contribution checklist?
buildcommand runs locallySecurity checklist?
dangerouslySetInnerHTMLPreview?
N/A