Upd. ContactsEncoder. Content search improved.

[alexandergull]

https://app.doboard.com/1/task/56146

[Copilot]

Copilot review overview

🟡 Changes recommended

Unresolved moderate findings remain in raw-text handling, attribute processing, and PHP compatibility metadata.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 3

Open (3)

• Raw blocks are modified before raw-range guard runs · New
• Skipping template contents leaves contacts unencoded · New
• Composer metadata lacks the required PHP 7.4 constraint · New

What changed in this PR

Updates contact matching with raw-text range indexing, offset-aware encoding, improved link/attribute handling, and PHP 7.4 compatibility targets.

Changes:

• Adds raw-text detection and precise match offsets.
• Refines mailto:/tel: processing and attribute cleanup.
• Updates Psalm and PHPCS compatibility targets.

File	Summary and findings
tests/​psalm.xml	Raises the PHP target. Moderate (2 votes): add the matching PHP constraint to composer.json for intdiv() compatibility (line 14).
tests/​.phpcs.xml	Raises the PHPCompatibility target.
Helper/​ContactsEncoderHelper.php	Adds markup indexing and raw-text checks. Moderate (2 votes): template contents are incorrectly skipped (lines 38, 81). Moderate (1 vote): opening raw-text tags can be corrupted because they fall outside indexed ranges (line 308). Nit (1 vote): add coverage for newly supported raw-text tags and boundary cases (line 38).
ContactsEncoder.php	Applies offset-aware matching and revised link handling. Moderate (2 votes): the pre-pass can alter raw blocks before the guard runs (lines 322, 327, 930). Moderate (1 vote): the mailto: fast path can corrupt excluded attributes or option text (line 333).

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.