Added support for grant type password #57#87
Open
ermissa wants to merge 2 commits into
Open
Conversation
Clancey
reviewed
May 22, 2019
Clancey
left a comment
Clancey
left a comment
Owner
There was a problem hiding this comment.
There are a couple of changes I think we should do, to make it a little more simple!
| import "package:http/http.dart" as http; | ||
| import "dart:async"; | ||
|
|
||
| class OauthPasswordAuthenticator extends OAuthAuthenticator { |
Owner
There was a problem hiding this comment.
Lets add an interface for the verifyCredentials. Then we can use it for BasicAuth and OAuthPassword.
| import 'package:flutter/material.dart'; | ||
| import 'package:simple_auth/simple_auth.dart'; | ||
|
|
||
| class OauthPasswordLoginPage extends StatefulWidget { |
Owner
There was a problem hiding this comment.
Lets do one credential entry, So we should merge your changes into https://github.com/Clancey/simple_auth/blob/master/simple_auth_flutter/lib/basic_login_page.dart Have it use the interface. Then both can use the same page, and any other that need username/password.
Author
|
Sorry I was busy, I will start to implement remaining parts tomorrow. |
|
any news here? |
|
@zaubererty See "Resource Owner Password Grant" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.