hardening(docs): pepper rule as plain JS so key minting runs on node 20 - #24
Merged
Merged
Conversation
…ode 20 lib/auth/mcp-pepper.ts becomes lib/auth/mcp-pepper.mjs (no imports), with types in mcp-pepper.d.mts. The resolver, scripts/mint-mcp-key.mjs and check:mcp-keys all load the .mjs, so the documented mint command works on any supported node, not only node >= 22.18. A test asserts that the mint script and the shared rule import no TypeScript file. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012cD3fDq5vhh2YWZPU2SV6H
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Small hardening follow-up to #23:
scripts/mint-mcp-key.mjsimported a.tsfile, so it ran only on node ≥ 22.18.lib/auth/mcp-pepper.mjs(plain JS, no imports), with types inmcp-pepper.d.mts. The resolver, the mint script andcheck:mcp-keysall load it.Tests and commands: main: 109 passed / 4 skipped. This PR: 110 / 4. The run used node 22.21.1 and npm 10.9.4:
npm ci,audit --audit-level=high,typecheck,test,build,verify:bundle,content-lint --strict,sbom. All green.🤖 Generated with Claude Code
https://claude.ai/code/session_012cD3fDq5vhh2YWZPU2SV6H